Page MenuHomePhabricator

Remove "Download QR" link from the sidebar
Open, Needs TriagePublic

Description

Currently, clicking on "get short url" produce both QR and the short url for the user:

grafik.png (541×537 px, 32 KB)

Thus the link to download the QR is mostly adding clutter to the sidebar and is making the whole sidebar less useful:

grafik.png (229×393 px, 21 KB)

Probably we could rename the link from "get short url" to "share" and move it to somewhere slightly more prominent (e.g top of the sidebar group).

Thoughts?

Event Timeline

Would that set the scene for the UrlShortener extension being a place to put other sharing features? e.g. someone might suggest a Open Graph preview thing (showing the page image and short description). Not sure if that's a worry.

Would that set the scene for the UrlShortener extension being a place to put other sharing features? e.g. someone might suggest a Open Graph preview thing (showing the page image and short description). Not sure if that's a worry.

To my understanding OG tags are added via core and PageImages extension. I don't see a reason why that should go into urlshortener and not core itself.

Oh no, I mean the preview of the metadata, as in: if you open a 'share' dialog, it might be good to see a preview of what you'd share if you pasted the URL into Mastodon or whatever (the 'card' view, I think it's called sometimes). Not necessarily from OG, perhaps the OEmbed stuff will happen at some point. But my main point was about scope creep of UrlShortener if it were to be exposed as just "Share". Perhaps it'd just be a matter of adding a JS hook with which other extensions could modify the dialog contents.

Ah okay. Eventually yeah, it should move to core and url shortener and others could add content via hooks. Not sure for now though (since we are not adding OG preview to url shortener now).

Jdlrobson-WMF subscribed.

Outside scope of Reader Experience Team but this removal makes sense to me and happy to review any patch.

Would that set the scene for the UrlShortener extension being a place to put other sharing features? e.g. someone might suggest a Open Graph preview thing (showing the page image and short description). Not sure if that's a worry.

Perhaps a share button there would be worth exploring?

Came here while searching to see if this issue was already reported. Should mention T413650 here as well.

Change #1245306 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/UrlShortener@master] Remove 'Download QR code' link from sidebar

https://gerrit.wikimedia.org/r/1245306

Change #1245306 merged by jenkins-bot:

[mediawiki/extensions/UrlShortener@master] Remove 'Download QR code' link from sidebar

https://gerrit.wikimedia.org/r/1245306