Page MenuHomePhabricator

[MEX] M3.2.1 - First Pass - Basic UI of strings which trigger a dropdown
Closed, ResolvedPublic

Description

As a wikidata editor
I want to edit strings which trigger a dropdown on my mobile device
So that I can more easily update items

Acceptance Criteria

  • Activating the edit button opens the edit statements screen for datatypes Tabular data (string) , Geographic shape (string)
    • The edit button for these two statements are updated to codex's active state (blue)
  • The datatypes are read only (existing properties are displayed (but cannot be edited, i.e. the publish button remains inactive))
  • References and qualifiers are updated to include this datatype as well
  • Ranking functions but cannot be saved
  • header/foot of edit page and updates to display the new datatypes
  • layout of the page matches the figma files linked below

Question: Is it more or less complicated to separate adding the editing functionality of these datatypes when they're a statement vs as a qualifer/reference?

  • It would be more complicated to separate the two, so when functionality is added it will be done in one task for all locations

Tabular data (string)

Screenshot 2025-09-09 at 16.03.44.png (840×1 px, 215 KB)

Figma here

Geographic shape (string)

Screenshot 2025-09-09 at 16.03.57.png (1×1 px, 183 KB)

Figma here

Event Timeline

@Alice.moutinho , please add the UI overview for these datatypes and replace the lorem ipsum with the specifics of the datatype, thanks!

Change #1188847 had a related patch set uploaded (by Hasan Akgün (WMDE); author: Hasan Akgün (WMDE)):

[mediawiki/extensions/Wikibase@master] Basic UI of strings which trigger a dropdown

https://gerrit.wikimedia.org/r/1188847

Handover notes:

  • Added named slots to current modal overlay component
  • Modified current addStatementButton component as well
  • Added a few events to achieve model reactivity (not done yet)

I think it can be a good start but still need to add tabular and geographic shape types

Change #1193099 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] [WIP] Implementing the tabular and geo-shape data.

https://gerrit.wikimedia.org/r/1193099

Change #1193100 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] [WIP] Implementing the Jest testing and E2E.

https://gerrit.wikimedia.org/r/1193100

Change #1193101 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] Implementing the Jest testing and E2E.

https://gerrit.wikimedia.org/r/1193101

Change #1193102 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] Rebasing fixes.

https://gerrit.wikimedia.org/r/1193102

One AC got dropped due to parallel work on the same feature by another colleague:

  • References and qualifiers are updated to include this datatype as well

The references and qualifiers do not have the requested datatypes yet, it could be another follow-up ticket.

Change #1193102 abandoned by Mahmoud-abdelsattar:

[mediawiki/extensions/Wikibase@master] Rebasing fixes.

Reason:

Restructuring rebase

https://gerrit.wikimedia.org/r/1193102

Change #1193100 abandoned by Mahmoud-abdelsattar:

[mediawiki/extensions/Wikibase@master] [WIP] Implementing the Jest testing and E2E.

Reason:

Restructuring rebase

https://gerrit.wikimedia.org/r/1193100

Change #1194106 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] Adding Statemetn and Qualifiers datatypes / Tests

https://gerrit.wikimedia.org/r/1194106

Change #1193099 abandoned by Mahmoud-abdelsattar:

[mediawiki/extensions/Wikibase@master] [WIP] Implementing the tabular and geo-shape data.

Reason:

Rebased in another patch

https://gerrit.wikimedia.org/r/1193099

Change #1193101 abandoned by Mahmoud-abdelsattar:

[mediawiki/extensions/Wikibase@master] Implementing the Jest testing and E2E.

Reason:

Rebased in another patch

https://gerrit.wikimedia.org/r/1193101

mahmoud.abdelsattar.wmde renamed this task from [MEX] M3.2.1 - First Pass - Basic UI of strings which trigger a dropdown to [MEX] M3.2.1 - First Pass - Basic UI of strings which trigger a dropdown.Oct 7 2025, 8:26 AM
mahmoud.abdelsattar.wmde removed mahmoud.abdelsattar.wmde as the assignee of this task.

Change #1188847 abandoned by Mahmoud-abdelsattar:

[mediawiki/extensions/Wikibase@master] Basic UI of strings which trigger a dropdown

Reason:

Rebased into another patch

https://gerrit.wikimedia.org/r/1188847

Change #1194939 had a related patch set uploaded (by Mahmoud-abdelsattar; author: Mahmoud-abdelsattar):

[mediawiki/extensions/Wikibase@master] Adding Statemetn and Qualifiers datatypes / Tests

https://gerrit.wikimedia.org/r/1194939

Change #1194939 abandoned by Mahmoud-abdelsattar:

[mediawiki/extensions/Wikibase@master] Adding Statemetn and Qualifiers datatypes / Tests

Reason:

changed to another patch

https://gerrit.wikimedia.org/r/1194939

Change #1194106 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Adding Statement and Qualifiers datatypes / Tests

https://gerrit.wikimedia.org/r/1194106

Change #1196653 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Reuse existing $settings in SettingsValueProvider() calls

https://gerrit.wikimedia.org/r/1196653

Change #1196654 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Send repo settings to JS code as JSON file

https://gerrit.wikimedia.org/r/1196654

Change #1196657 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] Use mw.ForeignApi instead of fetch()

https://gerrit.wikimedia.org/r/1196657

Change #1196653 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Reuse existing $settings in SettingsValueProvider() calls

https://gerrit.wikimedia.org/r/1196653

Change #1196654 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Send repo settings to JS code as JSON file

https://gerrit.wikimedia.org/r/1196654

Change #1196657 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use mw.ForeignApi instead of fetch()

https://gerrit.wikimedia.org/r/1196657

This is working on statements and qualifiers but not on references

Created a Follow-up task for the Reference new string types drop down implementation.
https://phabricator.wikimedia.org/T409268