Page MenuHomePhabricator
Create Task
Maniphest T403993

handle JSON fetch errors and reduce severity on trivial log noise
Closed, ResolvedPublic
Actions

Description

  1. Our logs get clogged with unhandled json errors such as wikilambda_fetch threw a fetching error: invalid json response body at http://localhost:6501/w/api.php?action=wikilambda_fetch&format=json&uselang=content&zids=Z27244 reason: Unexpected token 'u', "upstream c"... is not valid JSON. We can add error-handling for this type of error and reduce the log severity.
  2. We also get a lot of noise on 'error's such as: TypeError: Cannot read properties of undefined (reading 'Z6091K1'). We can also reduce the severity on this so we don't have weed through these logs every day.
  3. Lower severity on Skipping setting page property for label in unknown language... warnings in WikiLambda

Details

Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
handle json fetch errors and demote those logsrepos/abstract-wiki/wikifunctions/function-orchestrator!459ecarggrace/T403993/handle-json-fetch-errorsmain
Customize query in GitLab

Related Objects

Event Timeline

ecarg created this task.Sep 8 2025, 5:32 PM
ecarg triaged this task as Low priority.
ecarg renamed this task from handle JSON fetch errors to handle JSON fetch errors and reduce severity on trivial log noise.Sep 8 2025, 5:34 PM
ecarg updated the task description. (Show Details)
Jdforrester-WMF raised the priority of this task from Low to Medium.Sep 10 2025, 3:32 PM
Jdforrester-WMF moved this task from To Triage to Engineering Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF added a project: function-orchestrator.
ecarg added a project: WikiLambda.Sep 15 2025, 5:21 PM
ecarg updated the task description. (Show Details)
Jdforrester-WMF subscribed.Sep 16 2025, 2:42 PM

We can add error-handling for this type of error and reduce the log severity.

We already have error handling here; I agree we should reduce the log severity.

We also get a lot of noise on 'error's such as: TypeError: Cannot read properties of undefined (reading 'Z6091K1'). We can also reduce the severity on this so we don't have weed through these logs every day.

Do we understand why these are happening? Maybe this task should be about that?

Lower severity on Skipping setting page property for label in unknown language... warnings in WikiLambda

That's not relevant to this task, and it's already covered in T402670.

CodeReviewBot added a project: Patch-For-Review.Sep 30 2025, 9:04 PM

ecarg opened https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/459

Draft: handle json fetch errors and demote some logs

ecarg changed the task status from Open to In Progress.Sep 30 2025, 9:54 PM
ecarg claimed this task.
CodeReviewBot added a comment.Oct 3 2025, 6:58 PM

ecarg closed https://gitlab.wikimedia.org/repos/abstract-wiki/wikifunctions/function-orchestrator/-/merge_requests/459

handle json fetch errors and demote those logs

ecarg added a comment.Oct 3 2025, 7:07 PM

above closed MR is being done here instead

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2025, 7:31 PM
ecarg closed this task as Resolved.EditedTue, Nov 18, 5:45 AM

Invalid json errors are handled now and I haven't seen those errors come up anymore.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits