<gallery> rendering difference in packed mode
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	ssastry
	Sep 8 2025, 8:45 PM

Project Tags

Referenced Files

None

Subscribers

Aklapper

ssastry

Description

Look at Parsoid vs Legacy.

If you look at the source for that gallery, the second line is just a File: prefix (localized to the wiki) without any image. Legacy seems to ignore those, but Parsoid rendering something for it.

This is likely a WONT-FIX since Parsoid needs to rt-back content on edits. But, filing this phab task to record it if we decline it. But, we could perhaps add a lint (or update any existing lints for this).

Details

Related Changes in Gerrit:

Subject	Author	Repo	Branch	Lines +/-
Bump wikimedia/parsoid to 0.22.0-a26	OSleger	mediawiki/vendor	master	+304 -80
Packed mode gallery thumbs have min 60px width	Arlolra	mediawiki/services/parsoid	master	+43 -0
Add file to ParserTestRunner to test gallery packed mode	Arlolra	mediawiki/core	master	+28 -2

Customize query in gerrit

Event Timeline

ssastry created this task.Sep 8 2025, 8:45 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptSep 8 2025, 8:45 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

MSantos edited projects, added: Content-Platform-Team (Work In Progress); removed: Content-Platform-Team.Sep 11 2025, 2:11 PM

MSantos moved this task from Backlog to Investigate if this is our bug on the Content-Platform-Team (Work In Progress) board.

cscott moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Sep 18 2025, 2:25 PM

cscott moved this task from Uncategorized to Small Size Wikipedias on the Parsoid-Read-Views board.Sep 18 2025, 2:34 PM

cscott edited projects, added: Parsoid-Read-Views (Small Size Wikipedias); removed: Parsoid-Read-Views.

ABreault-WMF claimed this task.Sep 25 2025, 1:21 AM

ABreault-WMF triaged this task as Medium priority.

ABreault-WMF moved this task from Investigate if this is our bug to In Progress on the Content-Platform-Team (Work In Progress) board.

the second line is just a File: prefix (localized to the wiki) without any image. Legacy seems to ignore those, but Parsoid rendering something for it.

I think that's a red herring,

$ echo "<gallery>\nFile:\n</gallery>" | php bin/parse.php
<ul class="gallery mw-gallery-traditional" typeof="mw:Extension/gallery" about="#mwt1" data-parsoid='{"dsr":[0,26,9,10]}' data-mw='{"name":"gallery","attrs":{},"body":{}}'>
</ul>

$ echo "<gallery>\nНяйф:\n</gallery>" | php bin/parse.php --domain mdf.wikipedia.org
<ul class="gallery mw-gallery-traditional" typeof="mw:Extension/gallery" about="#mwt1" data-parsoid='{"dsr":[0,30,9,10]}' data-mw='{"name":"gallery","attrs":{},"body":{}}'>
</ul>

Change #1191212 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] Packed mode gallery images have min 60px

https://gerrit.wikimedia.org/r/1191212

gerritbot added a project: Patch-For-Review.Sep 25 2025, 1:30 AM

ABreault-WMF moved this task from In Progress to Code Review on the Content-Platform-Team (Work In Progress) board.Sep 25 2025, 1:30 AM

ABreault-WMF renamed this task from <gallery> rendering difference for missing images to <gallery> rendering difference in packed mode.Sep 25 2025, 7:16 PM

Change #1191492 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/core@master] Add file to ParserTestRunner to test gallery packed mode

https://gerrit.wikimedia.org/r/1191492

Change #1191492 merged by jenkins-bot:

[mediawiki/core@master] Add file to ParserTestRunner to test gallery packed mode

https://gerrit.wikimedia.org/r/1191492

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 29 2025, 6:00 PM

Change #1191212 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Packed mode gallery thumbs have min 60px width

https://gerrit.wikimedia.org/r/1191212

Maintenance_bot removed a project: Patch-For-Review.Sep 29 2025, 10:32 PM

ABreault-WMF moved this task from Code Review to To Deploy on the Content-Platform-Team (Work In Progress) board.Sep 30 2025, 2:29 PM