Page MenuHomePhabricator
Create Task
Maniphest T404087

Create a dev entry-point to support the development of structured task onboardings
Closed, ResolvedPublic
Actions

Description

Background
Currently, to develop the onboarding dialog for structured tasks, one needs to go through the process of selecting a task from the Homepage, be forwarded to VE, wait for the VE session to load, and then the onboarding shows up with one's local changes. On top of that there are issues with old javascript being stored in the browser by MediaWikis ResourceLoader system.

Acceptance Criteria
Create a new dev-entry point based, if possible on Vite's dev server, that allows loading the App.vue in modules/ext.growthExperiments.StructuredTask.PreEdit/App.vue and subcomponents required from within there. That dev-server should ideally also support Hot Module Replacement (HMR).

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Create dev entry point for StructuredTask PreEdit onboardingCyndywikimemediawiki/extensions/GrowthExperimentsmaster+1 K -24
chore(deps): update cypress-terminal-reportMichael Großemediawiki/extensions/GrowthExperimentsmaster+26 -40
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Sep 9 2025, 1:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2025, 1:56 PM
gerritbot added a comment.Sep 11 2025, 10:34 AM

Change #1187388 had a related patch set uploaded (by Cyndywikime; author: Cyndywikime):

[mediawiki/extensions/GrowthExperiments@master] Create dev entry point for StructuredTask PreEdit onboarding

https://gerrit.wikimedia.org/r/1187388

gerritbot added a project: Patch-For-Review.Sep 11 2025, 10:34 AM
Cyndymediawiksim edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team.Sep 11 2025, 2:47 PM
Cyndymediawiksim moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.Sep 11 2025, 2:52 PM
Cyndymediawiksim mentioned this in T404574: Create OnboardingDialog component structure with stepper functionality.Sep 15 2025, 10:58 AM
Sgs subscribed.Sep 16 2025, 1:55 PM

Is the expectation that the code produced is both compatible with the development setup and the production one? Or are you thinking of compiling a bundle with the outcome of modules/ext.growthExperiments.StructuredTask.PreEdit/common and App.vue? The import mechanism may be a problem for both JS and less files. I believe that's why we ended up with a build the last time we tried this. cc @Cyndymediawiksim @Michael

Michael added a comment.Sep 18 2025, 11:59 AM
In T404087#11185165, @Sgs wrote:

Is the expectation that the code produced is both compatible with the development setup and the production one? Or are you thinking of compiling a bundle with the outcome of modules/ext.growthExperiments.StructuredTask.PreEdit/common and App.vue? The import mechanism may be a problem for both JS and less files. I believe that's why we ended up with a build the last time we tried this. cc @Cyndymediawiksim @Michael

Yes, having the files be both compatible with the development setup and the production environment is the goal. It is tricky. But compiled files in Wikimedia production are really not great, and I'd like to avoid them.

The import mechanism for Less is fine with a bit more config support, as far as I can tell. But making require( ... ) actually work everywhere is the real challenge here.

Michael claimed this task.Sep 23 2025, 4:58 PM
Michael added a subscriber: Cyndymediawiksim.
Restricted Application added a project: User-Michael. · View Herald TranscriptSep 23 2025, 4:58 PM
Michael triaged this task as High priority.Sep 29 2025, 11:30 AM
gerritbot added a comment.Sep 29 2025, 11:33 AM

Change #1192100 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] chore(deps): update cypress-terminal-report

https://gerrit.wikimedia.org/r/1192100

Michael added a comment.Sep 29 2025, 12:12 PM

The two associated changes are now ready for review. Currently, the two plugins are very simple fakes, to be refined in the future. If you happen to know of more elaborate fakes already existing somewhere, I'd be happy to take them over! Somehow, I doubt we're the first tackling this issue.

gerritbot added a comment.Sep 30 2025, 9:07 AM

Change #1192100 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] chore(deps): update cypress-terminal-report

https://gerrit.wikimedia.org/r/1192100

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).Sep 30 2025, 10:00 AM
KStoller-WMF edited projects, added: Growth-Team (FY2025-26 Q2 Sprint 1); removed: Growth-Team (Current Sprint).Oct 7 2025, 5:00 PM
Michael moved this task from Incoming to Code Review on the Growth-Team (FY2025-26 Q2 Sprint 1) board.Oct 7 2025, 5:09 PM
gerritbot added a comment.Oct 8 2025, 10:04 AM

Change #1187388 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Create dev entry point for StructuredTask PreEdit onboarding

https://gerrit.wikimedia.org/r/1187388

Maintenance_bot removed a project: Patch-For-Review.Oct 8 2025, 10:34 AM
Michael closed this task as Resolved.Oct 8 2025, 11:38 AM

I don't think that meaningful QA can be done here. This was literally only about developer-facing functionality.

Michael mentioned this in T407362: Finish ReviseTone onboarding quiz functionality.Oct 15 2025, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits