Page MenuHomePhabricator

gravy lastname missing for gpay failed create payment 2025-09-09
Closed, ResolvedPublicBUG REPORT

Description

if we are not getting donor info from our form but from 3rd parties
we might miss some required info for create payment: as example below

2025-09-09T14:58:54+00:00 [INFO] (RawData) Create payment response {"type":"error","code":"bad_request","status":400,"message":"Request failed validation","details":[{"location":"body","pointer":"\/buyer\/billing_details\/last_name","message":"String should have at least 1 character","type":"string_too_short"}]}
for order id 235447353.3

Placeholder N/A in smashpig level, to pass the create payment but not pass to civi, while risk for recurring then ipn message will have the last name as Na..?
or can Gr4vy handle this case? https://wikimedia.slack.com/archives/C070F1DVBRN/p1757457577833079

zgrep -c string_too_short payments-misc-202509*.gz
payments-misc-20250901.gz:9
payments-misc-20250902.gz:26
payments-misc-20250903.gz:15
payments-misc-20250904.gz:149
payments-misc-20250905.gz:64
payments-misc-20250906.gz:49
payments-misc-20250907.gz:62
payments-misc-20250908.gz:47
payments-misc-20250909.gz:29
payments-misc-20250910.gz:92

Event Timeline

AnnWF renamed this task from Add a placeholder for gpay and applepay if no name required in our form to validate required field for gpay, applepay, venmo if no input from our form.Sep 9 2025, 4:56 PM
AnnWF updated the task description. (Show Details)
AnnWF renamed this task from validate required field for gpay, applepay, venmo if no input from our form to gravy lastname missing for gpay failed create payment.Sep 10 2025, 1:32 AM
AnnWF updated the task description. (Show Details)
AnnWF added a parent task: T403769: Gr4vy Chaos Epic.
Cstone renamed this task from gravy lastname missing for gpay failed create payment to gravy lastname missing for gpay failed create payment 2025-09-09.Sep 10 2025, 2:58 PM

They suggest to not pass null to skip validation check

Change #1187124 had a related patch set uploaded (by Wfan; author: Wfan):

[wikimedia/fundraising/SmashPig@master] Do not add last_name if last_name not exist

https://gerrit.wikimedia.org/r/1187124

Change #1187124 merged by jenkins-bot:

[wikimedia/fundraising/SmashPig@master] Do not add last_name if last_name not exist

https://gerrit.wikimedia.org/r/1187124

XenoRyet set Final Story Points to 2.