Page MenuHomePhabricator

MinervaPersonalMenu configuration option cannot be toggled in isolation from MinervaAdvancedMainMenu
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT

Description

Background

We are exploring adapting the default logged in experience to show the personal menu. However when enabling the personal menu, it currently results in duplicate elements in the advanced menu.

Steps to replicate the issue (include links if applicable):

  • Add the following to LocalSettings.php:
$wgMinervaPersonalMenu['loggedin'] = true;
$wgMinervaPersonalMenu['amc'] = true;
$wgMinervaAdvancedMainMenu['loggedin'] = false;
$wgMinervaAdvancedMainMenu['amc'] = false;
  • Visit a page and log in

What happens?:

  • There are two menus with duplicate items

Screenshot 2025-09-09 at 12.07.33 PM.png (726×1 px, 571 KB)

Screenshot 2025-09-09 at 12.07.09 PM.png (354×1 px, 314 KB)

What should have happened instead?:

  • The items in the personal menu should not be repeated in the main menu

Screenshot 2025-09-09 at 12.07.09 PM.png (354×1 px, 314 KB)

Screenshot 2025-09-09 at 12.06.56 PM.png (349×1 px, 331 KB)

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change #1186582 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Default main menu should consider MinervaPersonalMenu configuration

https://gerrit.wikimedia.org/r/1186582

LMora-WMF subscribed.

I picked up to do code review.

Change #1186582 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Default main menu should consider MinervaPersonalMenu configuration

https://gerrit.wikimedia.org/r/1186582

I checked (and compared with the current behavior in production)

  • for whether the issue described in the task can be reached via UX
  • for possible regression

No issues found.

Keeping the task in QA column to check in production wmf.7.