Page MenuHomePhabricator

replace {{formatnum:2000}} in a WikiLambda message
Closed, ResolvedPublicBUG REPORT

Description

In T395474, the message wikilambda-visualeditor-wikifunctionscall-dialog-search-placeholder was added. It includes the text {{formatnum:2000}}+.

There are two problems with it:

  1. formatnum must not be used in messages. Numbers must be formatted in the code that loads the message. See https://www.mediawiki.org/wiki/Manual:Messages_API
  2. The number may go above 2000 some day, so it should probably be changed to a parameter.

Event Timeline

Change #1211632 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] i18n: formatnum must not be used in messages.

https://gerrit.wikimedia.org/r/1211632

Change #1211632 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] i18n: Avoid using formatnum seach placeholder message

https://gerrit.wikimedia.org/r/1211632

@Amire80 I changed the i18n messages, if ok, could you close the ticket?