Page MenuHomePhabricator

[Reading List] Update the copy of Save action in tools menu
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

This ticket is a follow up work from this conversation to fix the copy of save action in the Tools menu. (Follow-up T400946: [Reading List] Behaviour of Watchlist, ReadingList menu items in Vector 2022).
When the "Save" action is in the tools menu it should use the copy "Save" / "Unsave" instead of the current "Add bookmark".

Requirements
  • Update the tools menu copy for Save action from "Save bookmark" to "Save".
  • When an item is already saved, then the copy changes to "Unsave"

Tools menu.png (1×733 px, 197 KB)

Requirement

Scope: Desktop web (Vector 2022).

  • Update the label text of the Reading List “Save” action in the Tools menu.
  • When the action is available but not yet used: display “Save”.
  • When the article is already saved: display “Unsave”.
  • The prior copy “Save bookmark” and “Add bookmark” must be removed entirely from the Tools menu.
  • The change applies only to the Tools menu entry, not to the toolbar or other locations.

BDD

Feature: Update Save action copy in Tools menu

  Scenario: Viewing a page not yet saved
    Given I am using Vector 2022
    And I have the Reading List feature enabled
    When I open the Tools menu on an article not yet saved
    Then the option label displays “Save”

  Scenario: Viewing a saved page
    Given I have already saved the article to my Reading List
    When I open the Tools menu again
    Then the option label displays “Unsave”

Test Steps

Test Case 1: Verify Save/Unsave copy in Tools menu

  1. Log in and enable Reading Lists feature.
  2. Open an article that has not been saved.
  3. Open the Tools menu.
  4. AC1: The menu item displays “Save”.
  5. Click the “Save” option to add the article to Reading List.
  6. Reopen the Tools menu.
  7. AC2: The menu item now displays “Unsave”.
  8. AC3: No instances of “Save bookmark” or “Add bookmark” appear in the UI.

QA Results - Beta

ACStatusDetails
1T404194#11325910
2T404194#11325910
3T404194#11325910

QA Results - Prod

ACStatusDetails
1T404194#11325922
2T404194#11325922
3T404194#11325922

Event Timeline

Sneha triaged this task as High priority.Sep 10 2025, 1:43 PM

I'd like to quickly check-in while estimating, seeing this now for the first time, before we go into action:

  1. While I somewhat agree with "Bookmark" could be confused with the browser bookmarks functionality, "Save" doesn't mean much to me. It could also be confused with "Save Page as…" functionality in the browser. Save what? And save to where? As user I'd feel to refrain from this action.
  2. Is "Unsave" a common word (non-native English speaker here), it's not at all common for me.

@Volker_E We discussed the copy and some of the concerns you have in this thread. We can add the word "article" after Save/Unsave if that makes it clear. Unsave is not common, just as Unwatch is not common either, still we have it in our UI. The problem with using a different word like "Remove" is that it can also be confusing. So we settled on Unsave. I think most people will not see this unless they are using Desktop at a smaller width.

Change #1198364 had a related patch set uploaded (by LorenMora; author: LorenMora):

[mediawiki/extensions/ReadingLists@master] [Reading List] Update the copy of Save action in tools menu

https://gerrit.wikimedia.org/r/1198364

Change #1198364 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] [Reading List] Update the copy of Save action in tools menu

https://gerrit.wikimedia.org/r/1198364

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Tahoe 26.x
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Verify Save/Unsave copy in Tools menu

  1. Log in and enable Reading Lists feature.
  2. Open an article that has not been saved.
  3. Open the Tools menu.
  4. AC1: The menu item displays “Save”.
  5. Click the “Save” option to add the article to Reading List.
  6. Reopen the Tools menu.
  7. AC2: The menu item now displays “Unsave”.
  8. AC3: No instances of “Save bookmark” or “Add bookmark” appear in the UI.

screenshot 144.mov.gif (1×618 px, 630 KB)

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Tahoe 26.x
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Verify Save/Unsave copy in Tools menu

  1. Log in and enable Reading Lists feature.
  2. Open an article that has not been saved.
  3. Open the Tools menu.
  4. AC1: The menu item displays “Save”.
  5. Click the “Save” option to add the article to Reading List.
  6. Reopen the Tools menu.
  7. AC2: The menu item now displays “Unsave”.
  8. AC3: No instances of “Save bookmark” or “Add bookmark” appear in the UI.

screenshot 145.mov.gif (962×618 px, 861 KB)

Edtadros updated the task description. (Show Details)
HFan-WMF claimed this task.