Page MenuHomePhabricator

Image Browsing: page scroll to article images does not work locally on mobile view
Closed, ResolvedPublic1 Estimated Story Points

Description

Overview

Clicking the "View in article" button should scroll the page to the position of the image in the wiki article. This scroll works in patchdemo, but is limited locally when using the Minerva skin and a mobile device in dev tools. I noticed that locally, it only scrolls to infobox images. When you select non-infobox images, the overlay closes but does not scroll to the position of that image in the article.

Acceptance Criteria

  • Page scrolls to the image in the article

Event Timeline

I _think_ this is an issue with the section collapsing in mobile view, and/or the lazy load images.

Taking this as I have suspisions on how to fix :D

Change #1187089 had a related patch set uploaded (by Bvibber; author: Bvibber):

[mediawiki/extensions/ReaderExperiments@master] Fix 'view in article' for lazy-loaded images, collapsed sections

https://gerrit.wikimedia.org/r/1187089

Change #1187089 merged by jenkins-bot:

[mediawiki/extensions/ReaderExperiments@master] Fix 'view in article' for lazy-loaded images, collapsed sections

https://gerrit.wikimedia.org/r/1187089

lwatson updated the task description. (Show Details)
lwatson set the point value for this task to 1.

Does this task need QA or should it go in sign-off?

@lwatson, If this is something that doesn't work locally I'm not sure this is something that needs to go through QA. Especially since this works on patchdemo (where I would test it).

Test wiki on Patch demo by LWatson-WMF using patch(es) linked to this task was deleted:

https://patchdemo.wmcloud.org/wikis/6b99d4c27c/w/