Page MenuHomePhabricator

Add a dialog to change the status associated with a suggested investigation
Closed, ResolvedPublic

Description

Background

  • We need a dialog that allows the user to change the status of a suggested investigation
  • The dialog should be able to
    • Change the status associated with an investigation
    • Give a reason for the change
    • Prefill the reason with "False positive" if the new status is "invalid" and the reason box is currently empty
  • Handling anything else, including updating the status shown outside the dialog, can be done in a separate task

Acceptance criteria

  • The dialog exists, can be opened by pressing the "edit" icon, and changes the status of the investigation

Event Timeline

Change #1187431 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] Add skeleton change status dialog

https://gerrit.wikimedia.org/r/1187431

Change #1187452 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Convert CharacterLimitedTextArea to be a input instead of textarea

https://gerrit.wikimedia.org/r/1187452

Change #1187460 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] SuggestedInvestigationsTablePager: Add data to edit button

https://gerrit.wikimedia.org/r/1187460

Change #1187452 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Convert CharacterLimitedTextArea to be a input instead of textarea

https://gerrit.wikimedia.org/r/1187452

Change #1187460 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SuggestedInvestigationsTablePager: Add data to edit button

https://gerrit.wikimedia.org/r/1187460

Change #1187431 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Implement the UI of the change status dialog

https://gerrit.wikimedia.org/r/1187431

Change #1187750 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Follow-up: SI: Implement the UI of the change status dialog

https://gerrit.wikimedia.org/r/1187750

Change #1187750 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Follow-up: SI: Implement the UI of the change status dialog

https://gerrit.wikimedia.org/r/1187750

Change #1187836 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] [WIP] SI: Make the dialog submit changes to the REST API

https://gerrit.wikimedia.org/r/1187836

Change #1187836 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Make the dialog submit changes to the REST API

https://gerrit.wikimedia.org/r/1187836

Prefill the reason with "False positive" if the new status is "invalid" and the reason box is currently empty

This thing from the task description is not implemented yet. This is not super critical, but I wanted to flag this (otherwise we'll have a contradictory information in the dialog itself). This is not a blocker for test wiki release

Prefill the reason with "False positive" if the new status is "invalid" and the reason box is currently empty

This thing from the task description is not implemented yet. This is not super critical, but I wanted to flag this (otherwise we'll have a contradictory information in the dialog itself). This is not a blocker for test wiki release

Good point, I had missed that.

Reopening

Change #1188361 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] SI: Show 'False positive' in notes by default when status invalid

https://gerrit.wikimedia.org/r/1188361

Change #1188361 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Show 'False positive' in notes by default when status invalid

https://gerrit.wikimedia.org/r/1188361