Page MenuHomePhabricator

[Mobile Reading list] Keep navigation menu option's location consistent across Advanced/Non-Advanced modes on Minerva
Closed, ResolvedPublic3 Estimated Story Points

Description

NOTE: This can be addressed by configuration once the bug in T404139: MinervaPersonalMenu configuration option cannot be toggled in isolation from MinervaAdvancedMainMenu is addressed.

Background

Currently, location of options in navigations menu can shift depending on whether a user has Advanced Mode turned on or off in settings. Menu items like "Watchlist", "Contributors", "User page", "Logout" etc change their location when the advanced mode is turned on/off.

Inconsistencies in the current experience

When Advanced mode in settings is turned off, "username", "watchlist", "contributions", and "log out" are in main menuWhen advanced mode in settings is turned on, ""username", "watchlist", "contributions", and "log out" are in user menu.
Screenshot 2025-09-10 at 12.44.51 PM.png (1×990 px, 233 KB)
Screenshot 2025-09-10 at 12.45.35 PM.png (1×992 px, 480 KB)

This creates the following issues for reading list implementation:

  • Onboarding complexity: We would need to point to two different locations for the same feature. e.g. when we introduce "Saved" functionality on mobile
  • Inconsistency: The UI when advanced mode is turned off is inconsistent with Desktop i.e. Saved may not always appear in the header
  • Learning friction: Users must relearn where to find items (e.g. accessing saved items) when toggling modes.

The above issues are also applicable to other menu items that change location.

Guiding principle

  • Advanced Mode should add more options for power users but it should not rearrange or relocate existing features.

Making the user menu visible on Mobile also enables future possibilities such as highlighting new features in a single/centralized location.

User Story

As a user, switching between Advanced and Non-advanced mode, I want the core menu items to remain in the same location, so that I don’t need to relearn where features are.

As a user, switching between Desktop and Mobile, I want the menu structure and feature locations to be consistent across platforms, so that I can navigate intuitively without having to relearn where items are.

Requirements

AMC (Advanced mobile contributions) mode = Advanced mode turned on in settings
non-AMC mode = Advanced mode turned off in settings

  • Logged out users should not see an icon in the top right corner. In the main menu they should see home, random, nearby, login, and settings (and donate if enabled on wiki)
  • non-AMC mode should display user icon menu in the header.
  • In non-AMC mode - the options "username", "watchlist", "contributions", and "log out" should be moved under user menu from main menu as shown below. The main menu (behind the hamburger icon) should not repeat any of the items in the user menu.
Article.png (699×384 px, 59 KB)
Article.png (699×384 px, 113 KB)
  • AMC mode is not impacted by this change and continues to show existing menus as shown below. The user menu should be identical to non-AMC and also contain user talk page and sandbox links (Install SandboxLink extension)
AMC mode - Current navigation options in main menuAMC mode - current navigation options in user menu
Article.png (699×384 px, 64 KB)
Article.png (699×384 px, 113 KB)
Link to Figma

Event Timeline

Jdlrobson-WMF added a project: MinervaNeue.
Jdlrobson-WMF moved this task from Backlog to Needs refinement on the Reader Experience Team board.
Sneha updated the task description. (Show Details)
Sneha added subscribers: HFan-WMF, Jdrewniak.
Jdlrobson-WMF changed the task status from Open to Stalled.Sep 10 2025, 11:11 PM
Sneha renamed this task from Keep feature locations consistent across Advanced/Non-Advanced modes on Minerva to [Mobile Reading list] Keep navigation menu option's location consistent across Advanced/Non-Advanced modes on Minerva.Nov 19 2025, 6:50 PM
Sneha updated the task description. (Show Details)
Sneha raised the priority of this task from Medium to Needs Triage.Nov 19 2025, 8:30 PM
bwang triaged this task as High priority.Nov 24 2025, 6:39 PM

Change #1210735 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Enable personal menu for logged in AMC disabled

https://gerrit.wikimedia.org/r/1210735

Test wiki created on Patch demo by Jdlrobson using patch(es) linked to this task:
https://c419e63dff.catalyst.wmcloud.org/w/

Jdlrobson-WMF set the point value for this task to 3.Dec 2 2025, 4:56 PM

From estimate:

Aside from the patch I posted above, It seems like the remaining work here would be to hide "talk" and "sandbox". We will probably need an additional feature flag for this one e.g. wgMinervaPersonalMenuEditorUserLinks to do that.

Just clarifying here that we are hiding "sandbox" and "talk" for when advanced mode is turned off. https://wikimedia.slack.com/archives/C09CSNCBTJ4/p1764010694390259

Jdlrobson-WMF changed the task status from Stalled to Open.Dec 4 2025, 4:40 PM
Jdlrobson-WMF updated the task description. (Show Details)

Just clarifying here that we are hiding "sandbox" and "talk" for when advanced mode is turned off. https://wikimedia.slack.com/archives/C09CSNCBTJ4/p1764010694390259

Yes. Up to you how you want to handle the removal of those links (e.g. new configuration or hardcoded removal)
I updated the QA steps.

SToyofuku-WMF subscribed.

Approved and moving to QA

A note came up during code review that save pages isn't quite in the right place in the menu. I'll try to remember to make a follow up ticket for that if nobody beats me to it

Change #1210735 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Keep navigation menu option's location consistent

https://gerrit.wikimedia.org/r/1210735

Just clarifying here that we are hiding "sandbox" and "talk" for when advanced mode is turned off. https://wikimedia.slack.com/archives/C09CSNCBTJ4/p1764010694390259

Yes. Up to you how you want to handle the removal of those links (e.g. new configuration or hardcoded removal)
I updated the QA steps.

@Jdlrobson-WMF - two questions

  • I still see "talk" on the patchdemo in non-AMC mode (see below). Do I need an updated patchdemo instance?
  • it seems that the patches are not yet in beta cluster?

Looks good - checked on https://c419e63dff.catalyst.wmcloud.org/w/index.php?title=Special:MobileOptions&returnto=Main+Page

non-AMCAMC
Screenshot 2025-12-09 at 7.57.17 PM.png (1×802 px, 163 KB)
Screenshot 2025-12-09 at 7.57.24 PM.png (1×806 px, 67 KB)
Screenshot 2025-12-09 at 7.56.55 PM.png (1×798 px, 171 KB)
Screenshot 2025-12-09 at 7.57.05 PM.png (1×794 px, 80 KB)

Just clarifying here that we are hiding "sandbox" and "talk" for when advanced mode is turned off. https://wikimedia.slack.com/archives/C09CSNCBTJ4/p1764010694390259

Yes. Up to you how you want to handle the removal of those links (e.g. new configuration or hardcoded removal)
I updated the QA steps.

Moving to Sign-Off column with couple of questions for @SToyofuku-WMF
(1)

Approved and moving to QA

A note came up during code review that save pages isn't quite in the right place in the menu. I'll try to remember to make a follow up ticket for that if nobody beats me to it

Does the task T409865: [Mobile Reading list] QA Access reading list from user menu address the issue you mentioned? Or you notice something else? I read comments on https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1210735, but still not sure whether the placement of "Saved pages" is incorrect. The current placement seems to me according to the figma design - https://www.figma.com/design/Q3pYKI7RRMdRRgkQp2RiTf/Web--Reading-List-Collections?node-id=1792-112993&t=hyRctv3m7B0uBTeI-0

Screenshot 2025-12-11 at 4.07.40 PM.png (1×796 px, 329 KB)
Screenshot 2025-12-11 at 4.10.11 PM.png (1×798 px, 305 KB)

Figma doesn't have Sandbox menu options and the patchdemo that I checked also did not have it. I suppose Sandbox option became hidden as per the specs.

(2) Is it going to be merged to beta cluster soon?

Change #1217595 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[operations/mediawiki-config@master] Enable MinervaPersonalMenu on beta for all logged in users

https://gerrit.wikimedia.org/r/1217595

Change #1217595 merged by jenkins-bot:

[operations/mediawiki-config@master] Enable MinervaPersonalMenu on beta for all logged in users

https://gerrit.wikimedia.org/r/1217595

@Etonkovidova I've enabled on the beta cluster for testing.

@HFan-WMF @SToyofuku-WMF I've created the follow up ticket to deploy this everywhere: T412465: Deployment: Enable personal menu for all logged in users please prioritize accordingly.

Testing I've noticed a bug...
If you create a new account on production, don't make an edit and visit the mobile site, the watchlist in the main menu defaults to the URL: Special:EditWatchlist
On beta cluster, with a new account I get navigated to Special:Watchlist (editor view).

This would need a follow up task like: https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1217804
(You can see the desired behaviour in mobile version of this patch demo user: patch pwd: patchdemo - click watchlist to get the reading list view)

Checked this on beta cluster and is working as expected except in the user menu "saved pages" should be below the "sandbox" in advanced mode, so as to maintain showing the cluster of users lists together in any mode. (This might be more applicable to T409865)

@Etonkovidova I've enabled on the beta cluster for testing.

Thank you, @Jdlrobson-WMF much appreciated!

Checked this on beta cluster and is working as expected except in the user menu "saved pages" should be below the "sandbox" in advanced mode, so as to maintain showing the cluster of users lists together in any mode. (This might be more applicable to T409865)

Thank you @Sneha - I've added a comment to T409865 and moved to Ready column to address it


Moving to Sign-off column - all follow-up tickets for outstanding issues found on this task have been filed. The scope of this task seems to be done.

Checked this on beta cluster and is working as expected except in the user menu "saved pages" should be below the "sandbox" in advanced mode, so as to maintain showing the cluster of users lists together in any mode. (This might be more applicable to T409865)

Tracked in T413413: [Mobile Reading Lists] AMC mode - change user menu option order to match desktop

Test wiki on Patch demo by Jdlrobson using patch(es) linked to this task was deleted:

https://c419e63dff.catalyst.wmcloud.org/w/