Make sure that sub-refs with the same listKey (copy and pasted) can be edited and saved with different content
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	WMDE-Fisch
	Sep 12 2025, 6:35 AM

Project Tags

Referenced Files

	F66025882: Screenshot from 2025-09-16 10-06-00.png
	Sep 16 2025, 10:31 AM

Subscribers

Aklapper

WMDE-Fisch

Description

Splitting the problem of C&P reuses on sub-refs. When C&Ping a sub-ref it's currently shown as a "real" reuse.

When the user edits a sub-ref that shares the same listKey as another one, we need to split the two so that they dont share the same content anymore.

Acceptance criteria

When there are two sub-ref nodes sharing the same listKey and the user edits on of the two, we need to create a new internalItem, and remap the new node.

Post Review care

Screenshot from 2025-09-16 10-06-00.png (605×242 px, 22 KB)

Don't show reuse warning in edit panel when editing details.

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	VE: Don't show reuse warning when editing details	WMDE-Fisch	mediawiki/extensions/Cite	master	+2 -1
	VE: Split reused sub-refs when editing only one of the reuses	WMDE-Fisch	mediawiki/extensions/Cite	master	+12 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined	BUG REPORT	None	T403381 Copy and pasting a sub-reference in VisualEditor temporarily leads to an unexpected (actual) re-use
		Resolved		None	T404415 Make sure that sub-refs with the same listKey (copy and pasted) can be edited and saved with different content

Event Timeline

WMDE-Fisch created this task.Sep 12 2025, 6:35 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2025, 6:35 AM

WMDE-Fisch renamed this task from Make sure that sub-refs with the same listKey are not merged in the reference list view. to Make sure that sub-refs with the same listKey can be edited and saved with different content.Sep 12 2025, 6:39 AM

WMDE-Fisch claimed this task.

WMDE-Fisch mentioned this in T403381: Copy and pasting a sub-reference in VisualEditor temporarily leads to an unexpected (actual) re-use.

WMDE-Fisch moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.

lilients_WMDE moved this task from Incoming to NEXT on the Cite (Sub-referencing) board.Sep 12 2025, 9:44 AM

lilients_WMDE moved this task from NEXT to Dev-Work on the Cite (Sub-referencing) board.

Change #1187812 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Split reused sub-refs when editing only one of the reuses

https://gerrit.wikimedia.org/r/1187812

gerritbot added a project: Patch-For-Review.Sep 12 2025, 1:36 PM

WMDE-Fisch moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.Sep 12 2025, 1:38 PM

WMDE-Fisch removed WMDE-Fisch as the assignee of this task.Sep 12 2025, 2:16 PM

Change #1187812 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Split reused sub-refs when editing only one of the reuses

https://gerrit.wikimedia.org/r/1187812

thiemowmde moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.Sep 15 2025, 7:56 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 15 2025, 8:03 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2025, 8:30 AM

Tobi_WMDE_SW moved this task from Demo to Done on the WMDE-TechWish-Sprint-2025-09-03-Salted-Caramel-Icecream board.Sep 16 2025, 8:17 AM

thiemowmde closed this task as Resolved.Sep 16 2025, 9:12 AM

WMDE-Fisch reopened this task as Open.Sep 16 2025, 10:26 AM

WMDE-Fisch added a project: WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream.

WMDE-Fisch updated the task description. (Show Details)

Change #1188740 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/Cite@master] VE: Don't show reuse warning when editing details

https://gerrit.wikimedia.org/r/1188740

gerritbot added a project: Patch-For-Review.Sep 16 2025, 10:29 AM

WMDE-Fisch moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream board.Sep 16 2025, 10:29 AM

WMDE-Fisch updated the task description. (Show Details)

WMDE-Fisch moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream board.Sep 16 2025, 10:54 AM

Change #1188740 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] VE: Don't show reuse warning when editing details

https://gerrit.wikimedia.org/r/1188740

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2025, 11:30 AM

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23); removed: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 16 2025, 12:01 PM

awight renamed this task from Make sure that sub-refs with the same listKey can be edited and saved with different content to Make sure that sub-refs with the same listKey (copy and pasted) can be edited and saved with different content.Sep 30 2025, 8:10 AM

awight moved this task from Demo to Done on the WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream board.Sep 30 2025, 8:13 AM

WMDE-Fisch closed this task as Resolved.Sep 30 2025, 9:10 AM

Make sure that sub-refs with the same listKey (copy and pasted) can be edited and saved with different contentClosed, ResolvedPublicActions