Page MenuHomePhabricator
Create Task
Maniphest T404459

Use ContentHolder to speed up Parsoid-related OutputTransform stages
Closed, ResolvedPublic
Actions

Description

We would like to eliminate a number of string-to-DOM-to-string conversions in the OutputTransform pipeline for parsoid.

First steps are T347062: Create ContentHolder interface and T348254: Add ParserOutput::getContentHolder().

Once that is done we need do a combination of rewriting text-only stages to have DOM equivalents and reordering stages to minimize the number of conversions necessary between HTML string form and DOM form.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Introduce ContentHolderTransformStagemediawiki/coremaster+109 -13
Use ContentHolder to implement/simplify ContentDOMTransformStagemediawiki/coremaster+29 -89
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT305161 Hard-deprecate and remove @deprecated methods from ParserOutput
 OpenihurbainT372592 Find a way to replace the use of ParserOutput::addJsConfigVars() in DiscussionTools
 OpenihurbainT376183 Use postprocessing cache for Discussion Tools
 ResolvedihurbainT380516 Introduce ParserOptions type for "propagated to ParserOutput but not otherwise affecting the parse"
 OpenNoneT363496 Collapsable sections split the parser cache
 OpenNoneT392227 [EPIC] Parsoid Performance
 ResolvedihurbainT293512 ParserOutput::getText() should be removed from ParserOutput
 ResolvedihurbainT348255 Parser cache infrastructure for OutputTransform
 ResolvedihurbainT348253 Create MediaWiki\ParserOutputTransform\DefaultOutputTransform
 ResolvedcscottT348254 Add ParserOutput::getContentHolder()
 ResolvedihurbainT404459 Use ContentHolder to speed up Parsoid-related OutputTransform stages
 OpencscottT380517 Make Parsoid language conversion into an OutputTransform pass
 OpenBUG REPORTNoneT400140 Existed links render as redlinks in Template
 OpencscottT415435 Add temporary URL request parameter to opt-in to the new Parsoid LanguageConverter implementation
 OpenNoneT267067 Make language variant a parser option
 OpenNoneT346996 Move page view language detection logic / functions out of LanguageConverter class and stop using global state
 ResolvedKrinkleT299369 Consider removing global $userLang from onPageContentLanguage hook
 ResolvedKrinkleT341244 ParserOptions and Title::getPageViewLanguage may disagree on the lang/dir
 ResolvedDAlangi_WMFT350806 Phase out Title::getPageViewLanguage in favour of ParserOutput metadata
OpencscottT416104 Use proper variant in ParsoidLocalization on messages localized into the page language
 OpenihurbainT410916 Allow requesting postprocessed output for some/many/most/all APIs which accept a ParserOption (in some form) and emit a ParserOutput (in some form)
 ResolvedihurbainT410919 Allow ParserOutputAccess to generate (and cache) postprocessed output for use in Article read views
 ResolvedihurbainT410923 Clone ParserOutput in Article before post-processing
 OpenihurbainT412803 Tweak unsafe post-processing cache keys
 ResolvedcscottT413227 Section edit links appear in wrong user interface language on Parsoid Read View wikis
 OpenihurbainT414359 Use postprocessing cache in FlaggedRevisions
 OpenNoneT411401 Eliminate double-parse and double-postprocess in CommonsMetadata
 ResolvedPRODUCTION ERRORcscottT412959 Logstash poolcounter warnings "Usage error: You may only aquire a single non-nowait lock" on wikis with post-processing cache enabled
 OpenihurbainT413795 Use ParserOptions in the post-processing pipeline rather than the options array

Event Timeline

cscott created this task.Sep 12 2025, 4:30 PM
gerritbot added a comment.Sep 12 2025, 4:33 PM

Change #1187008 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Use ContentHolder to implement/simplify ContentDOMTransformStage

https://gerrit.wikimedia.org/r/1187008

gerritbot added a project: Patch-For-Review.Sep 12 2025, 4:33 PM
gerritbot added a comment.Sep 15 2025, 7:47 PM

Change #1187008 merged by jenkins-bot:

[mediawiki/core@master] Use ContentHolder to implement/simplify ContentDOMTransformStage

https://gerrit.wikimedia.org/r/1187008

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Sep 15 2025, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 15 2025, 8:30 PM
cscott moved this task from Needs Triage to Performance on the Parsoid board.Sep 18 2025, 2:24 PM
ihurbain claimed this task.Sep 22 2025, 3:50 PM
gerritbot added a comment.Sep 23 2025, 1:00 PM

Change #1150712 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):

[mediawiki/core@master] Introduce ContentHolderTransformStage

https://gerrit.wikimedia.org/r/1150712

gerritbot added a project: Patch-For-Review.Sep 23 2025, 1:00 PM
gerritbot added a comment.Oct 3 2025, 8:35 PM

Change #1150712 merged by jenkins-bot:

[mediawiki/core@master] Introduce ContentHolderTransformStage

https://gerrit.wikimedia.org/r/1150712

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.22; 2025-10-07); removed MW-1.45-notes (1.45.0-wmf.19; 2025-09-16).Oct 3 2025, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 3 2025, 9:30 PM
ihurbain moved this task from Backlog to Performance on the Parsoid-Read-Views (Performance) board.Oct 10 2025, 2:30 PM
cscott closed this task as Resolved.Nov 3 2025, 5:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits