Page MenuHomePhabricator

Prepare and check storage layer for tokwiki
Closed, ResolvedPublic

Description

The new wiki's visibility will be: Public.

Event Timeline

FCeratto-WMF changed the task status from Open to In Progress.Sep 22 2025, 9:22 AM
FCeratto-WMF claimed this task.
FCeratto-WMF triaged this task as Medium priority.
FCeratto-WMF moved this task from Triage to In progress on the DBA board.

Preparation completed.

Mentioned in SAL (#wikimedia-operations) [2025-11-04T17:24:31Z] <fnegri@cumin1003> START - Cookbook sre.wikireplicas.add-wiki for database tokwiki (T404566)

Mentioned in SAL (#wikimedia-operations) [2025-11-04T17:24:40Z] <fnegri@cumin1003> END (PASS) - Cookbook sre.wikireplicas.add-wiki (exit_code=0) for database tokwiki (T404566)

I sent the SAL to the wrong task (should have been T404570: [wikireplicas] Create views for new wiki tokwiki), but there is something missing: I'm not finding tokwiki in any section, at least not in the ones that are replicated to wikireplicas.

I don't see any comment of the database being created - Federico maybe you prepared this beforehand when the database wasn't created?
If that's the case we should revert back and remove at least the grants to avoid any possible data leak (which isn't really possible if the aren't any views)
@fnegri you confirm no views are created right?

Ok so this is wrong and could have potentially resulted in a data leak - fortunately the database wasn't yet created otherwise if the database is created and the views applied before sanitization, we would have exposed data that shouldn't be there.

root@clouddb1020.eqiad.wmnet[(none)]> show grants for labsdbuser;
| GRANT SELECT, SHOW VIEW ON `tokwiki_p`.* TO `labsdbuser`           |
135 rows in set (0.001 sec)

root@clouddb1020.eqiad.wmnet[(none)]> nopager;
PAGER set to stdout
root@clouddb1020.eqiad.wmnet[(none)]> show databases like 'tok%';
Empty set (0.002 sec)

The database is not created so this task needs to be reopened.
For now, I've removed those grants from the clouddb* hosts.

root@clouddb1020.eqiad.wmnet[(none)]> revoke SELECT, SHOW VIEW ON `tokwiki_p`.* from labsdbuser;
Query OK, 0 rows affected (0.002 sec)

root@clouddb1020.eqiad.wmnet[(none)]> pager grep tok
PAGER set to 'grep tok'
root@clouddb1020.eqiad.wmnet[(none)]> show grants for labsdbuser;
134 rows in set (0.001 sec)





root@clouddb1016.eqiad.wmnet[(none)]> pager grep tok
PAGER set to 'grep tok'
root@clouddb1016.eqiad.wmnet[(none)]> show grants for labsdbuser;
| GRANT SELECT, SHOW VIEW ON `tokwiki_p`.* TO `labsdbuser`           |
135 rows in set (0.001 sec)

root@clouddb1016.eqiad.wmnet[(none)]> revoke SELECT, SHOW VIEW ON `tokwiki_p`.* from labsdbuser;
Query OK, 0 rows affected (0.002 sec)

root@clouddb1016.eqiad.wmnet[(none)]> show grants for labsdbuser;
134 rows in set (0.001 sec)







root@an-redacteddb1001.eqiad.wmnet[(none)]> pager grep tok
PAGER set to 'grep tok'
root@an-redacteddb1001.eqiad.wmnet[(none)]> show grants for labsdbuser;
| GRANT SELECT, SHOW VIEW ON `tokwiki_p`.* TO `labsdbuser`           |
135 rows in set (0.002 sec)

root@an-redacteddb1001.eqiad.wmnet[(none)]> revoke SELECT, SHOW VIEW ON `tokwiki_p`.* from labsdbuser;
Query OK, 0 rows affected (0.006 sec)

root@an-redacteddb1001.eqiad.wmnet[(none)]> show grants for labsdbuser;
134 rows in set (0.002 sec)
Marostegui added a subscriber: FCeratto-WMF.

Removing the assignee as we aren't the ones creating wikis.

@fnegri you confirm no views are created right?

Yes, no views were created for tokwiki because the db was not found.

Section s5: Wikis tokwiki redacted - marostegui@cumin1003

Section s5: Wikis tokwiki set up on clouddb - marostegui@cumin1003

Marostegui claimed this task.

All sanitized.