Page MenuHomePhabricator
Create Task
Maniphest T404587

[Epic] Fix VisualDiff for incompatibilities with sub-references
Open, Needs TriagePublic
Actions

Description

We introduced subreferences to references. The Visual Editor diff view behaves badly when subreferences are present. Lets check for issues and list them in the document and as subtasks.

There is some technical background to how the visual diff handles references—some logic was included to override the actual before-and-after numbering and to suppress some of the numbering differences, in order to handle the problem of one added ref causing a numbering ripple throughout the document.

Document with findings

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update VE core submodule to master (35c6564c9)mediawiki/extensions/VisualEditormaster+1 -1
Code cleanups in ve.DiffMatchPatchVisualEditor/VisualEditormaster+44 -45
Mark private VisualDiff methods as @privateVisualEditor/VisualEditormaster+59 -6
[WIP] Render visual diff items with actual numberVisualEditor/VisualEditormaster+40 -65
Customize query in gerrit

Related Objects
Search...

Event Timeline

lilients_WMDE created this task.Sep 15 2025, 12:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2025, 12:47 PM
lilients_WMDE added a subtask: T397319: VisualDiff: Subref footnote markers show the wrong number.Sep 15 2025, 12:49 PM
lilients_WMDE mentioned this in WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream.Sep 16 2025, 9:46 AM
lilients_WMDE added a project: WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream.Sep 16 2025, 9:57 AM
lilients_WMDE moved this task from Incoming to Later on the Cite (Sub-referencing) board.Sep 16 2025, 10:08 AM
lilients_WMDE claimed this task.Sep 16 2025, 3:06 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream board.
lilients_WMDE renamed this task from Investigation: check VisualDiff for compatability issues with subreferences to Investigate VisualDiff for incompatibilities with subreferences.Sep 16 2025, 3:35 PM
lilients_WMDE updated the task description. (Show Details)
lilients_WMDE removed lilients_WMDE as the assignee of this task.Sep 18 2025, 3:07 PM
lilients_WMDE moved this task from Doing to Tech Review on the WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream board.
lilients_WMDE updated the task description. (Show Details)
lilients_WMDE moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2025-09-16-Green-Tea-Icecream board.Sep 23 2025, 12:27 PM
WMDE-Fisch closed this task as Resolved.Sep 30 2025, 9:10 AM
lilients_WMDE reopened this task as Open.Apr 23 2026, 2:54 PM

Re-opening because we found another one. I create a subticket for that.

lilients_WMDE created subtask T424232: VisualDiff does not show change of a main+details edit.Apr 23 2026, 2:59 PM
lilients_WMDE renamed this task from Investigate VisualDiff for incompatibilities with subreferences to Fix VisualDiff for incompatibilities with subreferences.Apr 23 2026, 3:03 PM
awight renamed this task from Fix VisualDiff for incompatibilities with subreferences to Fix visual diff for incompatibilities with subreferences.Apr 24 2026, 6:38 AM
awight updated the task description. (Show Details)
awight added a project: VisualEditor.
awight updated the task description. (Show Details)
awight updated the task description. (Show Details)
zdev changed the status of subtask T397319: VisualDiff: Subref footnote markers show the wrong number from Open to Stalled.Apr 24 2026, 3:29 PM
zdev mentioned this in T397501: [Epic] Fix issues with {{reflist}} or missing references lists and main+details sub-references.Apr 24 2026, 3:47 PM
thiemowmde renamed this task from Fix visual diff for incompatibilities with subreferences to [Epic] Fix VisualDiff for incompatibilities with sub-references.Apr 27 2026, 9:22 AM
thiemowmde added projects: Epic, VisualEditor-VisualDiffs.
thiemowmde added subscribers: thiemowmde, Lina_Farid_WMDE, WMDE-Fisch.
lilients_WMDE added a project: WMDE-TechWish-Sprint-2026-05-12-Fungi.Fri, May 15, 2:14 PM
lilients_WMDE moved this task from Sprint Backlog to Epics / Watching / Stalled on the WMDE-TechWish-Sprint-2026-05-12-Fungi board.
gerritbot added a comment.Mon, May 18, 12:41 PM

Change #1288831 had a related patch set uploaded (by Awight; author: Awight):

[VisualEditor/VisualEditor@master] [POC] Visual diff becomes aware of sub-references

https://gerrit.wikimedia.org/r/1288831

gerritbot added a project: Patch-For-Review.Mon, May 18, 12:41 PM
gerritbot added a comment.Mon, May 18, 1:14 PM

Change #1288852 had a related patch set uploaded (by Awight; author: Awight):

[VisualEditor/VisualEditor@master] [WIP] Render visual diff items with actual number

https://gerrit.wikimedia.org/r/1288852

gerritbot added a comment.Tue, May 19, 6:19 AM

Change #1289165 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Code cleanups in ve.DiffMatchPatch

https://gerrit.wikimedia.org/r/1289165

gerritbot added a comment.Tue, May 19, 8:35 AM

Change #1289271 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[VisualEditor/VisualEditor@master] Mark private VisualDiff methods as @private

https://gerrit.wikimedia.org/r/1289271

awight changed the status of subtask T397319: VisualDiff: Subref footnote markers show the wrong number from Stalled to Open.Wed, May 20, 10:17 AM
gerritbot added a comment.Sun, May 31, 2:35 PM

Change #1289165 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] Code cleanups in ve.DiffMatchPatch

https://gerrit.wikimedia.org/r/1289165

gerritbot added a comment.Mon, Jun 1, 11:57 AM

Change #1295877 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (35c6564c9)

https://gerrit.wikimedia.org/r/1295877

gerritbot added a comment.Mon, Jun 1, 2:01 PM

Change #1295877 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (35c6564c9)

https://gerrit.wikimedia.org/r/1295877

Tobi_WMDE_SW added a project: WMDE-TechWish-Sprint-2026-06-09-Wild-Strawberries.Tue, Jun 9, 8:46 AM
Tobi_WMDE_SW moved this task from Sprint Backlog to Epics / Watching / Stalled on the WMDE-TechWish-Sprint-2026-06-09-Wild-Strawberries board.
WMDE-Fisch closed subtask T424232: VisualDiff does not show change of a main+details edit as Resolved.Tue, Jun 9, 8:49 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits