Page MenuHomePhabricator

Suggestions: share feedback after completing/dismissing a suggestion
Open, Needs TriagePublic

Assigned To
None
Authored By
ppelberg
Sep 15 2025, 4:00 PM
Referenced Files
F92264464: Captura de pantalla 2026-07-07 a las 13.34.17.png
Tue, Jul 7, 12:37 PM
F92264391: Captura de pantalla 2026-07-07 a las 13.33.43.png
Tue, Jul 7, 12:37 PM
F82371032: image.png
May 18 2026, 11:04 AM
F81110619: image.png
May 12 2026, 10:37 AM
F72963747: image.png
Mar 17 2026, 3:23 PM
F72963744: image.png
Mar 17 2026, 3:23 PM
F71610567: Captura de pantalla 2026-01-26 a las 17.20.06.png
Jan 26 2026, 4:20 PM
F71610563: image.png
Jan 26 2026, 4:19 PM

Description

Background goal

As part of T424677, we observed that:

  1. Users need a success confirmation after completing a suggestion. Suggestions that are applied automatically without user input were particularly confusing, while suggestions requiring manual input like "Add citation" were better understood since users could understand their own action reflected in the text.
  2. Users understood what the Dismiss action means, but they lacked feedback after using it. Some users expected a confirmation message (os some clarification on that) after dismissing a suggestion. Others were uncertain whether dismissing a suggestion would affect only their session or all editors.

As a solution, we should communicate the feedback after completing/dismissing a suggestion.

NOTE: we will need to be consistent with Edit Checks T387259

Artifacts

Captura de pantalla 2026-07-07 a las 13.33.43.png (1,244×894 px, 145 KB)
Captura de pantalla 2026-07-07 a las 13.34.17.png (1,804×1,314 px, 271 KB)
mobiledesktop

After completing a suggestion:

  • Use a success Toast
  • Highlighted the affected text in background-color-success-subtle while the success Toast is shown, making the connection between the action and the result explicit

After dismissing a suggestion:

  • Use a notice Toast
  • Optionally include a Undo button in the Toast to allow users to undo dismissing the suggestion

Acceptance criteria (or Done)

  • Evaluate possible solutions and decide on the best approach
  • Implement decided solution (in both Suggestions and Checks)

Event Timeline

One idea is shown in our components design ( https://www.figma.com/design/H8xtCDg3nc7rJ3XmgCKeNK/Edit-Check---features?node-id=1-2&p=f&t=oAVXcTQYmUbUq84r-0 ):

image.png (852×291 px, 37 KB)

image.png (852×291 px, 41 KB)

There are some problems with showing the success state in the card stack:

  • May be technically difficult, checks are rendered when they are valid. Having a check still exist for some time after it has been resolved would add complexity.
  • Assuming the message only persists for a few seconds, this could result in other checks jumping vertically after that time if checks are bunched up. Moving click targets at random times is a bad UX.
  • In pre-save check mode we only show one check at a time. One would either need a different experience, or only show the check for a short period of time, but even then that could slow down a user trying to dismiss a lot of checks quickly.

@Esanders the idea behind using a completed state instead a Toast was:

  1. Avoid using a success Toast with a green color which would include another color code apart from the yellow warning checks and the blue suggestions.
  2. Keep the success feedback visually close to the card the user just interacted with, instead of a Toast that always appears in the same corner and feels disconnected from the card being completed.

Captura de pantalla 2026-01-26 a las 17.20.06.png (2,460×990 px, 611 KB)

I’m not attached to a specific solution here, just interested in whether there is a technically feasible way to keep the success feedback localized to the card's position without being disruptive.

Regarding the pre-save moment, we could also discuss whether a completed/success state is really needed there, since that flow already relies on pagination to navigate a list of cards. In contrast, during mid-edit, a localized completed/success feedback could make more sense, as checks are distributed across different places in the article.

bmartinezcalvo renamed this task from Design Suggestion Mode "Success" state/feedback to Suggestions: Introduce a success state when completing a suggestion.Mar 17 2026, 3:28 PM
bmartinezcalvo renamed this task from Suggestions: Introduce a success state when completing a suggestion to Suggestions: share feedback after completing/dismissing a suggestion.Tue, Jul 7, 12:37 PM
bmartinezcalvo updated the task description. (Show Details)

Based on intern conversations, we decided to reuse existing components instead of creating custom states. So sharing the approach reusing existing components:

Captura de pantalla 2026-07-07 a las 13.33.43.png (1,244×894 px, 145 KB)
Captura de pantalla 2026-07-07 a las 13.34.17.png (1,804×1,314 px, 271 KB)
mobiledesktop

After completing a suggestion:

  • Use a success Toast
  • Highlighted the affected text in background-color-success-subtle while the success Toast is shown, making the connection between the action and the result explicit

After dismissing a suggestion:

  • Use a notice Toast
  • Optionally include a Undo button in the Toast to allow users to undo dismissing the suggestion