[Regression] Edit Check becomes unresponsive when clicked on back button after reaching the last check on the stack and scrolling back up to the top of the page
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ryasmeen
	Sep 15 2025, 10:20 PM

Description

Steps to reproduce:

Go to this page: https://en.wikipedia.beta.wmcloud.org/wiki/Fox?veaction=edit&ecenable=2
Add a new paragraph anywhere on the page.
Add some content from an external website somewhere that's not at the top of the page.
Click on Publish Changes button.
Observe that in the Pre-Save stage there are three checks now.
Click the down arrow to reach the end of the stack of checks.
Now scroll back up to the top of the page.
Click on the "Back" button to go back to the edit mode.

Observed Result:

Nothing happens, it gets stuck in that stage, there are some errors in the console. "TypeError: Cannot read properties of undefined (reading 'getHighlightSelections')"

Screenshot/Screen capture:

Screenshot 2025-09-15 at 2.42.04 PM.png (2×3 px, 1 MB)

Browser: Chrome

Environment: beta cluster

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Edit check dialog: reset "acting" when reusing the dialog	mediawiki/extensions/VisualEditor	master	+1 -0
	Edit check dialog: reset currentOffset when reusing the dialog	mediawiki/extensions/VisualEditor	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T404069: Pre-save check not scrolling into view correctly
Mentioned Here: T404069: Pre-save check not scrolling into view correctly

Event Timeline

Ryasmeen created this task.Sep 15 2025, 10:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2025, 10:20 PM

Ryasmeen updated the task description. (Show Details)Sep 15 2025, 10:22 PM

Observe that in the Pre-Save stage there are three checks now.

I only see one check. Can you provide more details here?

I can reproduce it, but it's not actually about leaving pre-save, it's really a side-effect of an error that happens when you enter pre-save without a focused action. Arguably, this could get folded in as a QA failure for T404069 which caused it.

DLynch claimed this task.Sep 15 2025, 11:02 PM

ppelberg edited projects, added Editing-team (Kanban Board); removed Editing-team.Sep 15 2025, 11:03 PM

ppelberg moved this task from Inbox to Doing on the Editing-team (Kanban Board) board.

Change #1188471 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check dialog: reset currentOffset when reusing the dialog

https://gerrit.wikimedia.org/r/1188471

gerritbot added a project: Patch-For-Review.Sep 15 2025, 11:03 PM

DLynch moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Sep 15 2025, 11:04 PM

Change #1188471 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check dialog: reset currentOffset when reusing the dialog

https://gerrit.wikimedia.org/r/1188471

Ryasmeen mentioned this in T404069: Pre-save check not scrolling into view correctly.Sep 16 2025, 12:54 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 16 2025, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2025, 1:32 AM

In T404661#11183134, @DLynch wrote:

Observe that in the Pre-Save stage there are three checks now.

I only see one check. Can you provide more details here?

There are supposed to be three checks, not one if you used ecenable=2 :
Reference Check for Step 2
Paste Check and Reference check for Step 3.

Screenshot 2025-09-15 at 6.44.21 PM.png (1×2 px, 517 KB)

DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Sep 16 2025, 2:02 AM

DLynch added a project: Editing QA.

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.Sep 16 2025, 3:14 PM

Ryasmeen edited projects, added Verified; removed Editing QA.

DLynch closed this task as Resolved.Sep 16 2025, 4:32 PM

VPuffetMichel added a project: OKR-Work.Dec 8 2025, 10:42 PM

Change #1218321 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/VisualEditor@master] Edit check dialog: reset "acting" when reusing the dialog

https://gerrit.wikimedia.org/r/1218321

gerritbot added a project: Patch-For-Review.Dec 15 2025, 4:05 PM

Change #1218321 merged by jenkins-bot: