Page MenuHomePhabricator
Create Task
Maniphest T404664

Clean up HTMLForm hack for 2FA login buttons in OATHAuth
Open, Needs TriagePublic
Actions

Description

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/1186136 introduces some terrible hackery to display multiple buttons that each set a different value for the newModule field. HTMLForm really doesn't want to let you do this.

To make this cleaner, we should introduce an HTMLFormField subclass (initially in OATHAuth, we can upstream it to core later) that implements a group of buttons with the same name (similar to radio buttons, but with submit buttons instead).

Related Objects

Event Timeline

Catrope created this task.Sep 15 2025, 10:47 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 15 2025, 10:47 PM
Catrope moved this task from Backlog to Consider for future work on the FY2025-26 WE4.6.2 Multiple Authenticators board.Sep 15 2025, 10:47 PM
Reedy moved this task from Backlog to Bugs on the MediaWiki-extensions-OATHAuth board.Sep 16 2025, 7:50 PM
Reedy added a project: Technical-Debt.Sep 16 2025, 8:20 PM
Catrope edited projects, added: FY2025-26 WE 4.6 - Account Security (WE 4.6.4 - 2FA improvements and passkey support); removed: FY2025-26 WE4.6.2 Multiple Authenticators.Oct 2 2025, 4:07 AM
Catrope moved this task from Inbox to Tech debt cleanup on the FY2025-26 WE 4.6 - Account Security (WE 4.6.4 - 2FA improvements and passkey support) board.Oct 2 2025, 6:17 PM
Catrope added a comment.Nov 13 2025, 12:27 AM

This would also be a good opportunity to fix T406584. Creating an HTMLFormField subclass for this should allow us to decouple the name(s) of the query string parameter(s) from the name of the form field, which would let us get away from all the buttons having the same name attribute and instead give each of them a different name.

TheDJ subscribed.Nov 13 2025, 9:08 AM
TBurmeister subscribed.Jan 6 2026, 5:48 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits