Page MenuHomePhabricator

CentralAuth tests failing
Closed, ResolvedPublic

Description

19:23:55 There were 2 errors:
19:23:55 
19:23:55 1) CentralAuthSessionProviderTest::testProvideSessionInfo
19:23:55 MediaWiki\Config\ConfigException: MediaWiki\Config\HashConfig::get: undefined option: 'SessionCookieJwtExpiration'
19:23:55 
19:23:55 /workspace/src/includes/config/HashConfig.php:61
19:23:55 /workspace/src/includes/session/CookieSessionProvider.php:478
19:23:55 /workspace/src/includes/session/CookieSessionProvider.php:566
19:23:55 /workspace/src/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php:305
19:23:55 /workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthSessionProviderTest.php:177
19:23:55 
19:23:55 2) CentralAuthSessionProviderTest::testPersistSession
19:23:55 MediaWiki\Config\ConfigException: MediaWiki\Config\HashConfig::get: undefined option: 'SessionCookieJwtExpiration'
19:23:55 
19:23:55 /workspace/src/includes/config/HashConfig.php:61
19:23:55 /workspace/src/includes/session/CookieSessionProvider.php:478
19:23:55 /workspace/src/includes/session/CookieSessionProvider.php:505
19:23:55 /workspace/src/includes/session/CookieSessionProvider.php:265
19:23:55 /workspace/src/extensions/CentralAuth/includes/session/CentralAuthSessionProvider.php:412
19:23:55 /workspace/src/extensions/CentralAuth/tests/phpunit/CentralAuthSessionProviderTest.php:246
19:23:55 
19:23:55

from https://integration.wikimedia.org/ci/job/quibble-composer-mysql-php82/5423/console on unrelated patch ContentMetadataCollector: temporarily broaden ::append* param types (1188459) · Gerrit Code Review

Seems to be caused by 3f0f4de28ff06cfbfcb6cff2df5e469782ca632e / https://gerrit.wikimedia.org/r/c/mediawiki/core/+/1185305

Event Timeline

Change #1188475 had a related patch set uploaded (by C. Scott Ananian; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@master] tests: Update for SessionCookieJwtExpiration added in core

https://gerrit.wikimedia.org/r/1188475

Change #1188475 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] tests: Update for SessionCookieJwtExpiration added in core

https://gerrit.wikimedia.org/r/1188475

Change #1188718 had a related patch set uploaded (by Gergő Tisza; author: Bartosz Dziewoński):

[mediawiki/extensions/CentralAuth@wmf/1.45.0-wmf.18] tests: Update for SessionCookieJwtExpiration added in core

https://gerrit.wikimedia.org/r/1188718

Change #1188718 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.45.0-wmf.18] tests: Update for SessionCookieJwtExpiration added in core

https://gerrit.wikimedia.org/r/1188718

Mentioned in SAL (#wikimedia-operations) [2025-09-16T13:29:43Z] <tgr@deploy1003> Started scap sync-world: Backport for [[gerrit:1188715|User: Simplify makeUpdateConditions() (T401748)]], [[gerrit:1188716|session: Add a mechanism for forcing a refresh (T399200)]], [[gerrit:1188717|Use short expiry for JWT cookies (T399200)]], [[gerrit:1188718|tests: Update for SessionCookieJwtExpiration added in core (T399200 T404667)]], [[gerrit:1188765|xLab: Fix instrument to produce valid events

Mentioned in SAL (#wikimedia-operations) [2025-09-16T13:35:39Z] <tgr@deploy1003> hueitan, tgr: Backport for [[gerrit:1188715|User: Simplify makeUpdateConditions() (T401748)]], [[gerrit:1188716|session: Add a mechanism for forcing a refresh (T399200)]], [[gerrit:1188717|Use short expiry for JWT cookies (T399200)]], [[gerrit:1188718|tests: Update for SessionCookieJwtExpiration added in core (T399200 T404667)]], [[gerrit:1188765|xLab: Fix instrument to produce valid events (T404420)]]

Mentioned in SAL (#wikimedia-operations) [2025-09-16T13:48:33Z] <tgr@deploy1003> Finished scap sync-world: Backport for [[gerrit:1188715|User: Simplify makeUpdateConditions() (T401748)]], [[gerrit:1188716|session: Add a mechanism for forcing a refresh (T399200)]], [[gerrit:1188717|Use short expiry for JWT cookies (T399200)]], [[gerrit:1188718|tests: Update for SessionCookieJwtExpiration added in core (T399200 T404667)]], [[gerrit:1188765|xLab: Fix instrument to produce valid events