Page MenuHomePhabricator
Create Task
Maniphest T404710

Find and replace loses document focus if started in the surface
Closed, ResolvedPublic
Actions

Description

  1. Open VE's find-and-replace (Ctrl+F)
  2. Search for something with multiple results (e.g. one or two letters)
  3. Press F3/Ctrl+G multiple times to see it stepping through the results
  4. Now focus the surface and try to step through the results again (F3/Ctrl+G multiple times)
  5. Observe that after the second press the browsers find-and-replace opens. This is because the first press moves the focus outside of the VE target.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (cfd45f5a8)Esandersmediawiki/extensions/VisualEditormaster+1 -1
WindowAction: Only call executeAction if a window is already openEsandersVisualEditor/VisualEditormaster+10 -0
Customize query in gerrit

Event Timeline

Esanders created this task.Sep 16 2025, 12:14 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2025, 12:14 PM
Esanders added a project: Regression.Sep 16 2025, 12:15 PM
Esanders added a comment.Sep 16 2025, 12:17 PM

Actually a regression from 6 years ago: https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/512655

gerritbot added a comment.Sep 16 2025, 12:39 PM

Change #1188766 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] WindowAction: Only call executeAction if a window is already open

https://gerrit.wikimedia.org/r/1188766

gerritbot added a project: Patch-For-Review.Sep 16 2025, 12:39 PM
Esanders added a project: Editing-team (Kanban Board).Sep 16 2025, 12:39 PM
Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Sep 16 2025, 1:25 PM
gerritbot added a comment.Sep 16 2025, 4:38 PM

Change #1188766 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] WindowAction: Only call executeAction if a window is already open

https://gerrit.wikimedia.org/r/1188766

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2025, 5:31 PM
Esanders claimed this task.Sep 18 2025, 10:06 AM
Esanders moved this task from Code Review to QA on the Editing-team (Kanban Board) board.
Esanders added a project: Editing QA.
gerritbot added a comment.Sep 19 2025, 12:06 PM

Change #1189853 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cfd45f5a8)

https://gerrit.wikimedia.org/r/1189853

gerritbot added a project: Patch-For-Review.Sep 19 2025, 12:06 PM
gerritbot added a comment.Sep 19 2025, 3:17 PM

Change #1189853 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cfd45f5a8)

https://gerrit.wikimedia.org/r/1189853

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2025, 3:31 PM
Ryasmeen closed this task as Resolved.Sep 30 2025, 11:06 PM
Ryasmeen edited projects, added: Verified; removed: Editing QA, Regression.
VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits