Page MenuHomePhabricator
Create Task
Maniphest T404712

Suggested investigations: Subtitle links are not rendered correctly when UserInfoCard / IP reveal is not enabled
Closed, ResolvedPublic0.1 Estimated Story PointsBUG REPORT
Actions

Description

The CheckUser-SuggestedInvestigations special page does not load the ext.checkUser.styles module which means that some styles can be missing if it isn't loaded for another reason

Steps to replicate the issue
  1. Open Special:SuggestedInvestigations using an account which does not have CheckUser-UserInfoCard or IP reveal enabled
  2. Look at the subtitle links

What happens?:
The subtitle links are not separated with | characters

image.png (983×157 px, 15 KB)

What should have happened instead?:
They should be separated in the same way that if the user had CheckUser-UserInfoCard loaded (or other code that causes ext.checkUser.styles to be loaded on all / most special pages)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
SI: Load ext.checkUser.styles on Special:SuggestedInvestigationsDreamy Jazzmediawiki/extensions/CheckUserwmf/1.45.0-wmf.19+1 -0
SI: Load ext.checkUser.styles on Special:SuggestedInvestigationsDreamy Jazzmediawiki/extensions/CheckUsermaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Dreamy_Jazz created this task.Sep 16 2025, 12:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2025, 12:22 PM
Dreamy_Jazz claimed this task.Sep 16 2025, 12:22 PM
Dreamy_Jazz added projects: CheckUser-SuggestedInvestigations, Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)), Trust and Safety Product Team.
Dreamy_Jazz set the point value for this task to 0.1.
Dreamy_Jazz moved this task from Priority Backlog to In Progress on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.
gerritbot added a comment.Sep 16 2025, 12:32 PM

Change #1188763 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] SI: Load ext.checkUser.styles on Special:SuggestedInvestigations

https://gerrit.wikimedia.org/r/1188763

gerritbot added a project: Patch-For-Review.Sep 16 2025, 12:32 PM
Dreamy_Jazz moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.Sep 16 2025, 12:40 PM
Dreamy_Jazz moved this task from Backlog to In Progress on the CheckUser-SuggestedInvestigations board.
Dreamy_Jazz added a parent task: T402025: [Epic]: Display suggested investigations to CheckUsers.Sep 16 2025, 12:42 PM
Dreamy_Jazz closed this task as Resolved.Sep 16 2025, 12:45 PM
Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.

Thanks for the quick merge

mszwarc moved this task from In Progress to Done on the CheckUser-SuggestedInvestigations board.Sep 16 2025, 1:00 PM
gerritbot added a comment.Sep 16 2025, 2:05 PM

Change #1188763 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] SI: Load ext.checkUser.styles on Special:SuggestedInvestigations

https://gerrit.wikimedia.org/r/1188763

Maintenance_bot removed a project: Patch-For-Review.Sep 16 2025, 2:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 16 2025, 3:01 PM
gerritbot added a comment.Sep 17 2025, 11:33 AM

Change #1189136 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@wmf/1.45.0-wmf.19] SI: Load ext.checkUser.styles on Special:SuggestedInvestigations

https://gerrit.wikimedia.org/r/1189136

gerritbot added a project: Patch-For-Review.Sep 17 2025, 11:33 AM
gerritbot added a comment.Sep 17 2025, 11:45 AM

Change #1189136 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@wmf/1.45.0-wmf.19] SI: Load ext.checkUser.styles on Special:SuggestedInvestigations

https://gerrit.wikimedia.org/r/1189136

Stashbot added a comment.Sep 17 2025, 11:46 AM

Mentioned in SAL (#wikimedia-operations) [2025-09-17T11:46:00Z] <dreamyjazz@deploy1003> Started scap sync-world: Backport for [[gerrit:1189136|SI: Load ext.checkUser.styles on Special:SuggestedInvestigations (T404712)]]

Stashbot added a comment.Sep 17 2025, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2025-09-17T11:51:39Z] <dreamyjazz@deploy1003> dreamyjazz: Backport for [[gerrit:1189136|SI: Load ext.checkUser.styles on Special:SuggestedInvestigations (T404712)]] synced to the testservers (see https://wikitech.wikimedia.org/wiki/Mwdebug). Changes can now be verified there.

Stashbot added a comment.Sep 17 2025, 11:57 AM

Mentioned in SAL (#wikimedia-operations) [2025-09-17T11:57:29Z] <dreamyjazz@deploy1003> Finished scap sync-world: Backport for [[gerrit:1189136|SI: Load ext.checkUser.styles on Special:SuggestedInvestigations (T404712)]] (duration: 11m 29s)

ReleaseTaggerBot edited projects, added: MW-1.45-notes (1.45.0-wmf.19; 2025-09-16); removed: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 17 2025, 12:01 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 17 2025, 12:30 PM
OKryva-WMF added a project: OKR-Work.Oct 3 2025, 3:45 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits