Page MenuHomePhabricator
Create Task
Maniphest T404720

Autoreveal sometimes adds broken Reveal IP links
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

Show IP buttons show next to each entry on the page. Clicking that button shows (error), and the API call is a local one (not cross-wiki).

What should have happened instead?:

Right now, no Show IP button is expected. T404718: Investigate: Adding Reveal IP button to Special:GlobalContributions asks for adding them.

Other information (browser name/version, screenshots, etc.):

This problem occurs for all pages that should have no IP reveal buttons.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
IP auto-reveal: On disabling, check that IP was revealed before adding buttonTchandersmediawiki/extensions/CheckUsermaster+16 -7
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm created this task.Sep 16 2025, 1:36 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 16 2025, 1:36 PM
Tchanders edited projects, added: Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)), Temporary accounts (Create/update essential tools/anti-abuse management), CheckUser; removed: Temporary accounts.Sep 19 2025, 6:14 AM
Tchanders updated the task description. (Show Details)
Tchanders merged a task: T404998: Disabling IP auto-reveal while on Special:GlobalContributions adds IP reveal buttons to the page.
Tchanders moved this task from Priority Backlog to Ready on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.
Tchanders added a subscriber: • Niharika.
Tchanders added subscribers: Tchanders, Urbanecm_WMF.
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Sep 19 2025, 10:02 AM
Tchanders claimed this task.Sep 22 2025, 8:49 AM
Tchanders moved this task from Ready to In Progress on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.
Tchanders added a comment.EditedSep 22 2025, 9:18 AM

What happens on disabling autoreveal?

ipReveal.disableAutoReveal calls ipReveal.hideAllIps, which looks for all temp user links on the page and adds IP reveal buttons next to them.

What should happen?

What should happen is the same as in dispatcher.js, which is that specific logic is executed depending on the page. This could mean only adding IP reveal if extra conditions are met, adding a different type of IP reveal button, or never adding any IP reveal buttons for that page.

The simplest way to ensure IP reveal buttons get added correctly would be to simply reload the page, which would run dispatcher.js again. We could add a warning to the dialog that the page will refresh if auto-reveal is switched off.

We decided not to reload the page when the mode changed in a code review discussion, where it was imagined that IP reveal may need switching on while the user is interacting with the page. The precise timing of switching off IP reveal is likely to be less sensitive, so the user can finish their interaction with the page before switching it off, if they want to avoid a page reload.

(Implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CheckUser/+/1190241 but abandoned in favour of the solution in T404720#11201016.)

Tchanders updated the task description. (Show Details)Sep 22 2025, 9:18 AM
gerritbot added a comment.Sep 22 2025, 11:07 AM

Change #1190238 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/CheckUser@master] IP auto-reveal: On disabling, check that IP was revealed before adding button

https://gerrit.wikimedia.org/r/1190238

gerritbot added a project: Patch-For-Review.Sep 22 2025, 11:07 AM
Tchanders added a comment.Sep 22 2025, 11:08 AM
In T404720#11200781, @Tchanders wrote:

The simplest way to ensure IP reveal buttons get added correctly would be to simply reload the page, which would run dispatcher.js again. We could add a warning to the dialog that the page will refresh if auto-reveal is switched off.

The patch does something simpler: only adds the button if there was a revealed IP.

Tchanders moved this task from In Progress to Needs Review on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.Sep 22 2025, 11:15 AM
Dreamy_Jazz moved this task from Inbox to Temporary account IP reveal on the CheckUser board.Sep 23 2025, 2:16 PM
Dreamy_Jazz moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)) board.Sep 26 2025, 3:43 PM
gerritbot added a comment.Sep 26 2025, 4:32 PM

Change #1190238 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] IP auto-reveal: On disabling, check that IP was revealed before adding button

https://gerrit.wikimedia.org/r/1190238

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 26 2025, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 26 2025, 5:31 PM
Dreamy_Jazz closed this task as Resolved.Oct 3 2025, 2:40 PM
Dreamy_Jazz subscribed.

I've assumed that this can be closed, so closing

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits