Page MenuHomePhabricator

[wmf.18] Add Image intro tours - onboarding graphics display images incorrectly
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue

  • On a wiki with Add image Structured task enabled (e.g. cswiki) go to Special:Homepage and go to any of "Add an image" suggested articles ( you can go to either of "Add an image to an unillustrated article" or "Add an image to an article section")
  • The intro tour will be displayed.

What happens?:

  • the images in the intro tour are incorrect -
Screenshot 2025-09-16 at 9.57.56 AM.png (1,070×1,090 px, 102 KB)
Screenshot 2025-09-15 at 6.05.13 PM.png (1,362×1,282 px, 198 KB)

What should have happened instead?:
For the correct images see
T298109: Add an image: onboarding graphics (desktop)
T292092: Add an image: overlay onboarding

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
KStoller-WMF moved this task from Inbox to Estimated tasks backlog on the Growth-Team board.

the same issue seems to happen for for "add a link" illustrations

image.png (750×1,626 px, 254 KB)

Sgs edited projects, added: Growth-Team (Current Sprint); removed: Growth-Team.
Sgs moved this task from Incoming to Code Review on the Growth-Team (Current Sprint) board.

Change #1189501 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/GrowthExperiments@master] Revert "Remove meaningless elements and attributes from SVG files"

https://gerrit.wikimedia.org/r/1189501

Change #1189501 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Revert "Remove meaningless elements and attributes from SVG files"

https://gerrit.wikimedia.org/r/1189501

I'm really sorry for the trouble. Thanks for the quick fix! I'm not entirely sure what happened. Maybe it was a rebase issue and not present in my original patchset 1? Maybe we didn't expect an <svg fill="none"> to be meaningful on the root <svg> element? I had a closer look at some of the affected files and it appears to be a quirk of the software used to create these images to place this kind of "reset" there. That makes it harder to reuse these images or parts of them in other contexts. But since that's not a requirement for these files it's better to leave these fill="none" untouched.

This looks like it can be closed out