Page MenuHomePhabricator

OATHAuth has low PHPUnit test coverage
Open, Needs TriagePublic

Description

https://doc.wikimedia.org/cover-extensions/OATHAuth/

src/:

  • 2026-04-08 - 47.74% of lines (1583 / 3316)
  • 2026-03-25 - 47.79% of lines (1579 / 3304)
  • 2026-03-24 - 48.36% of lines (1625 / 3360)
  • 2026-03-23 - 47.14% of lines (1584 / 3360)
  • 2026-03-22 - 46.02% of lines (1550 / 3368)
  • 2026-03-09 - 46.12% of lines (1502 / 3257)
  • 2026-02-13 - 43.96% of lines (1307 / 2973)
  • 2026-02-08 - 43.61% of lines
  • 2026-02-05 - 41.31% of lines
  • 2026-01-29 - 40.12% of lines (after WebAuthn was merged in)
  • 2026-01-02 - 54.10% of lines
  • 2025-12-03 - 51.14% of lines
  • 2025-11-10 - 39.73% of lines
  • 2025-11-06 - 37.63% of lines
  • 2025-09-17 - 19.87% of lines

maintenance/:

  • 2026-03-23 - 6.27% of lines (16 / 255)
  • 2026-03-20 - 5.49% of lines (14 / 255)
  • 2026-03-19 - 0.00% of lines (0 / 255)

Event Timeline

Hi @Reedy ,
I’d like to work on this task.
Is it still open and okay for me to proceed?

Hello @Yuvrajpatil17,

Yes the task is still open, as shown by the status in the top left.

You don't need to ask to work on task that are open, and especially ones that are unassigned.

If you wanted to write some tests that increase coverage, that'd be great, but I note that this may not always be the easiest on a codebase you're unfamiliar with.

TThanks @Reedy for the clarification.
I’ll start by adding some small PHPUnit tests to help improve coverage.

Change #1256555 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] Add test for UpdateSecretsValue

https://gerrit.wikimedia.org/r/1256555

Change #1256610 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] OATHAuthModuleRegistryTest: Add more tests to increase coverage

https://gerrit.wikimedia.org/r/1256610

Change #1256613 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] OATHAuthLogger: Add @codeCoverageIgnore when CheckUser not loaded

https://gerrit.wikimedia.org/r/1256613

Change #1256621 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Add some more covers for OATHAuthServices

https://gerrit.wikimedia.org/r/1256621

Change #1256622 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Add @covers for AuthKey

https://gerrit.wikimedia.org/r/1256622

Change #1256623 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] TOTPKey: Add some @codeCoverageIgnore

https://gerrit.wikimedia.org/r/1256623

Change #1256624 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test jsonSerialize()

https://gerrit.wikimedia.org/r/1256624

Change #1256626 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test setPasswordlessSupport()

https://gerrit.wikimedia.org/r/1256626

Change #1258351 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] DisableOATHAuthForUserTest: Go for 100% test coverage

https://gerrit.wikimedia.org/r/1258351

Change #1258351 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] DisableOATHAuthForUserTest: Go for 100% test coverage

https://gerrit.wikimedia.org/r/1258351

Change #1256610 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHAuthModuleRegistryTest: Add more tests to increase coverage

https://gerrit.wikimedia.org/r/1256610

Change #1256613 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] OATHAuthLogger: Add @codeCoverageIgnore when CheckUser not loaded

https://gerrit.wikimedia.org/r/1256613

Change #1256621 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Add some more covers for OATHAuthServices

https://gerrit.wikimedia.org/r/1256621

Change #1256622 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Add @covers for AuthKey

https://gerrit.wikimedia.org/r/1256622

Change #1256623 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] TOTPKey: Add some @codeCoverageIgnore

https://gerrit.wikimedia.org/r/1256623

Change #1256624 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test jsonSerialize()

https://gerrit.wikimedia.org/r/1256624

Change #1256626 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] WebAuthnKeyTest: Test setPasswordlessSupport()

https://gerrit.wikimedia.org/r/1256626

Change #1259223 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/OATHAuth@master] tests: Mark some tests as covering OATHUser

https://gerrit.wikimedia.org/r/1259223

Change #1259223 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] tests: Mark some tests as covering OATHUser

https://gerrit.wikimedia.org/r/1259223