Page MenuHomePhabricator
Create Task
Maniphest T404860

SelectionManager: When rendering highlights for lots of selections, only render those which are visible in the viewport
Closed, ResolvedPublic
Actions

Description

This optimisation already exists in FindAndReplaceDialog, where 100s of highlights are possible. When a threshold is hit, we limit search results to those that are within the viewport (or within 50px), and when the page is scrolled we recalculate.

This functionality should be brought into SelectionManager so it can be used by anyone rendering highlights, for example EditCheck in suggestion mode, which may highlight dozens of issues.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Update VE core submodule to master (cfd45f5a8)Esandersmediawiki/extensions/VisualEditormaster+1 -1
SelectionManager: Bring in viewport clipping logic from FindAndReplaceDialogEsandersVisualEditor/VisualEditormaster+75 -119
Customize query in gerrit

Event Timeline

Esanders created this task.Sep 17 2025, 1:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2025, 1:45 PM
gerritbot added a comment.Sep 17 2025, 1:46 PM

Change #1188412 had a related patch set uploaded (by Esanders; author: Esanders):

[VisualEditor/VisualEditor@master] SelectionManager: Bring in viewport clipping logic from FindAndReplaceDialog

https://gerrit.wikimedia.org/r/1188412

gerritbot added a project: Patch-For-Review.Sep 17 2025, 1:46 PM
gerritbot added a comment.Sep 17 2025, 5:30 PM

Change #1188412 merged by jenkins-bot:

[VisualEditor/VisualEditor@master] SelectionManager: Bring in viewport clipping logic from FindAndReplaceDialog

https://gerrit.wikimedia.org/r/1188412

Maintenance_bot removed a project: Patch-For-Review.Sep 17 2025, 5:30 PM
gerritbot added a comment.Sep 19 2025, 12:06 PM

Change #1189853 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cfd45f5a8)

https://gerrit.wikimedia.org/r/1189853

gerritbot added a project: Patch-For-Review.Sep 19 2025, 12:06 PM
gerritbot added a comment.Sep 19 2025, 3:17 PM

Change #1189853 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (cfd45f5a8)

https://gerrit.wikimedia.org/r/1189853

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 19 2025, 4:06 PM
Esanders moved this task from Inbox to Code Review on the Editing-team (Kanban Board) board.Sep 22 2025, 12:16 PM
DLynch moved this task from Code Review to QA on the Editing-team (Kanban Board) board.Oct 28 2025, 5:18 PM
DLynch added a project: Editing QA.
EAkinloose closed this task as Resolved.Nov 6 2025, 9:37 AM
EAkinloose edited projects, added: Verified; removed: Editing QA.
VPuffetMichel added a project: OKR-Work.Dec 8 2025, 10:11 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits