Page MenuHomePhabricator

Instrumentation: '.published_revision_id' should be integer
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • From the CX unified dashboard, using a desktop computer, select a draft translation
  • From the confirmation screen, select "Continue translation"
  • From the desktop translation editor, refresh the page

What happens?:

  • a "editor_close" event is logged but it's invalid because published_revision_id is formatted as string
  • a "editor_open" event is logged but it's invalid because published_revision_id is formatted as string

What should have happened instead?:

  • a valid "editor_close" event is logged with published_revision_id formatted as a number
  • a valid "editor_open" event is logged with published_revision_id formatted as a number

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):


Derived Requirement

Ensure that the .published_revision_id field in the CX unified dashboard instrumentation is logged as an integer. Both editor_open and editor_close events must include published_revision_id formatted as a number, not a string, to ensure validity of the events.

Test Steps

Test Case 1: Validate published_revision_id is an integer on editor open

  1. Open the CX unified dashboard on a desktop computer.
  2. Select a draft translation.
  3. On the confirmation screen, select "Continue translation".
  4. Open the browser developer console or use instrumentation logs to capture events.
  5. ✅❓❌⬜ AC1: Confirm that the editor_open event is logged and published_revision_id is formatted as a number (integer), not a string.

Test Case 2: Validate published_revision_id is an integer on editor close

  1. In the desktop translation editor, refresh the page or close the editor.
  2. Capture the instrumentation logs for the editor_close event.
  3. ✅❓❌⬜ AC2: Confirm that the editor_close event is logged and published_revision_id is formatted as a number (integer), not a string.

QA Results - TestWiki

ACStatusDetails
1T404863#11252759
2T404863#11252759

Event Timeline

SBisson triaged this task as Medium priority.
SBisson moved this task from Needs Triage to Translation editor on the ContentTranslation board.

Change #1189188 had a related patch set uploaded (by Sbisson; author: Sbisson):

[mediawiki/extensions/ContentTranslation@master] Instrumentation: ensure page id and rev id are numbers

https://gerrit.wikimedia.org/r/1189188

Change #1189188 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Instrumentation: ensure page id and rev id are numbers

https://gerrit.wikimedia.org/r/1189188

@SBisson There hasn't been a way to see those events in the browser for editor_close but you gave me a screenshot that you saw them in your local event intake server and on production. I will move this to Sign-off. Thanks for all your work!

Test Result - Test Wiki

Status: ✅ PASS
Environment: Test Wiki
OS: macOS Tahoe 26.0.1
Browser: Chrome 140
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Validate published_revision_id is an integer on editor open

  1. Open the CX unified dashboard on a desktop computer.
  2. Select a draft translation.
  3. On the confirmation screen, select "Continue translation".
  4. Open the browser developer console or use instrumentation logs to capture events.
  5. Click Refresh
  6. AC1: Confirm that the editor_open event is logged and published_revision_id is formatted as a number (integer), not a string.
2025-10-07_15-50-53.png (2,137×934 px, 399 KB)

Test Case 2: Validate published_revision_id is an integer on editor close

  1. In the desktop translation editor, refresh the page or close the editor.
  2. Capture the instrumentation logs for the editor_close event.
  3. AC2: Confirm that the editor_close event is logged and published_revision_id is formatted as a number (integer), not a string.

From sbisson who saw them in his local event intake server and on production.

2025-10-07_13-39-28.png (1,743×991 px, 285 KB)

GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
GMikesell-WMF moved this task from Needs QA to Design Signoff on the LPL Hypothesis board.