Page MenuHomePhabricator
Create Task
Maniphest T404878

Test on a Z11 shows [object Object] instead of result and expected value
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
It shows:
Expected result: [object Object]
Actual result: [object Object]

What should have happened instead?:
Expected result: "Albany is the capital of New York."
Actual result: ...?

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Metadata mixin: Make sure expectedTestResult and actualTestResult are transformed to stringsDaphne Smitmediawiki/extensions/WikiLambdamaster+75 -25
Customize query in gerrit

Event Timeline

DVrandecic created this task.Sep 17 2025, 3:25 PM
Jdforrester-WMF renamed this task from Test shows [object Object] instead of result and expected value to Test on a Z11 shows [object Object] instead of result and expected value.Sep 17 2025, 3:54 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To Triage to Bugs to investigate on the Abstract Wikipedia team board.
Jdforrester-WMF added a project: WikiLambda Front-end.
DSmit-WMF subscribed.Sep 19 2025, 10:16 AM

Expected result:

Screenshot 2025-09-19 at 12.13.32.png (1,024×600 px, 81 KB)

  1. Showing "Errors: None". Why: No 'errors' key in error metadata from API:
    • The UI says there are no errors because there is an expected and actual result in the error metadata from the orchestrator but there is not 'errors' key. So the UI thinks there are no errors.
    • Solution: Question is whether the orchestrator should return an 'errors' key yes or no (technically this IS an error) or that is should be fixed in the frontend code.
  2. The other issue why 'expectedTestResult' and 'actualTestResult' don't show up is because the K2 is not a string value (like the other metadata) but an object of Z11.
    • Solution: Question is whether the backend should return a string value or if the frontend should account for a Z11 object
DSmit-WMF changed the task status from Open to In Progress.Sep 19 2025, 10:17 AM
DSmit-WMF claimed this task.
DSmit-WMF added a comment.EditedSep 19 2025, 10:40 AM

As discussed in the team:

I will create a patch so the diff shows up as:

Screenshot 2025-09-19 at 12.32.34.png (1,012×638 px, 76 KB)

I will also set an error message instead of "None"

DSmit-WMF removed DSmit-WMF as the assignee of this task.Sep 19 2025, 10:40 AM
DSmit-WMF added a project: function-orchestrator.
gerritbot added a comment.Sep 19 2025, 10:42 AM

Change #1189825 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Metadata mixin: Make sure expectedTestResult and actualTestResult are transformed to strings

https://gerrit.wikimedia.org/r/1189825

gerritbot added a project: Patch-For-Review.Sep 19 2025, 10:42 AM
DSmit-WMF removed a project: function-orchestrator.Sep 19 2025, 11:02 AM
DSmit-WMF moved this task from Bugs to investigate to 26Q1 (Jul–Sep) on the Abstract Wikipedia team board.Sep 19 2025, 1:00 PM
DSmit-WMF edited projects, added: Abstract Wikipedia team (26Q1 (Jul–Sep)); removed: Abstract Wikipedia team.
DSmit-WMF moved this task from Incoming to In Code review on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.
DSmit-WMF claimed this task.Sep 19 2025, 2:10 PM
Jdforrester-WMF moved this task from In Code review to Ready to deploy on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Sep 23 2025, 1:57 PM
DSantamaria added a project: Essential-Work.Sep 24 2025, 10:12 AM
gerritbot added a comment.Sep 24 2025, 12:05 PM

Change #1189825 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Metadata mixin: Make sure expectedTestResult and actualTestResult are transformed to strings

https://gerrit.wikimedia.org/r/1189825

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2025, 12:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 24 2025, 1:00 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.Oct 2 2025, 4:03 PM
Jdforrester-WMF closed this task as Resolved.Oct 2 2025, 4:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits