Page MenuHomePhabricator
Create Task
Maniphest T404886

Show add reference check in mid-edit moment
Open, Needs TriagePublicFeature
Actions

Description

The add-reference check is currently only shown pre-save.

Our main reason for not showing it mid-edit originally was that we felt it’d be noisy, since it’d be appearing when the user very-plausibly was still intending to add a reference and just hadn’t finished writing yet. But now we have access to a signal that basically means “I have moved on from this paragraph”, in the form of the branchNodeChange listener that we added for tone check.

In the suggestion mode patch for T399612 I pulled add-reference into mid-edit only for suggestions.

Particularly as we're about to be adding tone and paste as mid-edit checks, this seems like something useful to fill out the ranks.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Run AddReferenceEditCheck when exiting a paragraphmediawiki/extensions/VisualEditormaster+1 -7
Customize query in gerrit

Related Objects

Event Timeline

DLynch created this task.Sep 17 2025, 4:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2025, 4:08 PM
gerritbot added a comment.Sep 17 2025, 5:40 PM

Change #1189266 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/VisualEditor@master] Run AddReferenceEditCheck when exiting a paragraph

https://gerrit.wikimedia.org/r/1189266

gerritbot added a project: Patch-For-Review.Sep 17 2025, 5:40 PM
PatchDemoBot added a comment.Sep 17 2025, 5:42 PM

Test wiki created on Patch demo by ESanders (WMF) using patch(es) linked to this task:
https://8b0d6822fa.catalyst.wmcloud.org/wiki/Douglas Adams?veaction=edit&ecenable=1

ppelberg moved this task from Backlog to Existing Feature Improvements on the EditCheck board.Sep 22 2025, 10:40 PM
ppelberg subscribed.
Sdkb subscribed.EditedOct 1 2025, 4:54 PM

I share the intuition that presenting the check mid-edit will be a better user experience than pre-save. However, that depends on the rate of erroneous triggers — if there's a high chance of it triggering when the user hasn't actually moved on, that could be annoying enough to negate the usability benefit.

DLynch added a comment.Oct 1 2025, 4:58 PM

It's the same trigger as Tone, so it depends on you moving your cursor outside the paragraph, which is presumably unusual if you're not done with that text. (Or at least, we're already going to be annoying people in this exact way with Tone, if we're wrong about that.)

ppelberg edited projects, added Editing-team (Planning); removed Editing-team.Oct 1 2025, 10:11 PM
ppelberg moved this task from Inbox to Needs Discussion on the Editing-team (Planning) board.
ppelberg mentioned this in T405383: Create a Grafana dashboard to track engagement with Edit Checks.Oct 13 2025, 11:36 PM
ppelberg moved this task from Needs Discussion to Inbox on the Editing-team (Planning) board.Mon, Nov 10, 6:05 PM
ppelberg removed a project: Editing-team (Planning).

I'm removing this ticket from the planning board as this work is not related to Editing Team priorities in Q2 FY25-26.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits