Page MenuHomePhabricator

Set Paste Check config default values
Closed, ResolvedPublic

Description

T403768 creates a config that enables volunteers, on a per-project basis, to enable/disable individual Edit Checks.

Requirements

This task involves the work of adjusting this config for Paste Check such that the following is true:

  • Wikis that are participating in the Paste Check controlled experiment (T399669) will see the config value set so that Paste Check is active by default. Read: Paste Check will activate if/when the requisite actions (e.g. pasted content ≥50 characters) are taken by people the Check is meant to be available to (e.g. ≤100 cumulative edits).
  • Wikis that are NOT participating in the Paste Check controlled experiment (T399669) will see the config value set so that Paste Check is NOT active by default.
NOTE: for wikis participating in the A/B test, any change they attempt to make to the configured value will be overridden by the value set through A/B test.

Done

  • Requirements are implemented

Event Timeline

ppelberg updated the task description. (Show Details)
ppelberg moved this task from Inbox to Ready to Be Worked On on the Editing-team (Kanban Board) board.
ppelberg edited subscribers, added: DLynch; removed: Trizek-WMF.

Boldly assigning this to David as the person who's been leading on this work.

When the paste check is disabled-by-config, should the logging we added for T402460#11174256 still happen?

Change #1190717 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Edit check: update some check-creation for config changes

https://gerrit.wikimedia.org/r/1190717

Change #1190718 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Paste check: set up for the A/B test

https://gerrit.wikimedia.org/r/1190718

When the paste check is disabled-by-config, should the logging we added for T402460#11174256 still happen?

Per standup, we want to know whether Paste Check would've been shown had it been enabled REGARDLESS of why it is not currently enabled (e.g. did we not enable it? did volunteers disable it? etc.)

Change #1190717 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Edit check: update some check-creation for config changes

https://gerrit.wikimedia.org/r/1190717

Change #1190718 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Paste check: set up for the A/B test

https://gerrit.wikimedia.org/r/1190718

DLynch added a project: Editing QA.

Part of what was implemented was the interaction with the a/b test, which won't be testable right now. However, what you can do on beta is test editing the MediaWiki:Editcheck-config.json file and adding a "paste": { enabled: true } section, which should turn on the paste check regardless of whether you're using ecenable. (Though bear in mind that all the normal account-based check restrictions will apply, so you may also need to adjust those settings.)

Change #1191091 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/VisualEditor@master] Paste check: logging shouldn't check nonDefaultChecks any more

https://gerrit.wikimedia.org/r/1191091

Change #1191091 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Paste check: logging shouldn't check nonDefaultChecks any more

https://gerrit.wikimedia.org/r/1191091