Page MenuHomePhabricator
Create Task
Maniphest T404939

CommunityConfiguration unconditionally requires CommunityConfigurationExample
Closed, ResolvedPublic
Actions

Description

On CI, when an extension depends on CommunityConfiguration, tests will fail cause it also requires CommunityConfigurationExample which force us to add it as a dependency to any extension that uses CommunityConfiguration. Currently CommunityConfigurationExample is being injected because CI processes dependencies recursively and we are removing that behavior (see T389998).

The affected extensions are: AutoModerator, Babel, CheckUser,Cite, GrowthExperiments, ReportIncident

A build would fail with:

1) MediaWiki\Extension\CommunityConfiguration\Tests\CommunityConfigurationTestHelpersTest::testOverrideProviderOK
InvalidArgumentException: Provider CommunityConfigurationExample is not supported

extensions/CommunityConfiguration/src/Provider/ConfigurationProviderFactory.php:100
extensions/CommunityConfiguration/tests/phpunit/CommunityConfigurationTestHelpers.php:42
extensions/CommunityConfiguration/tests/phpunit/integration/CommunityConfigurationTestHelpersTest.php:23
2) MediaWiki\Extension\CommunityConfiguration\Tests\Integration\UpdateEmergencyDefaultsTest::testUpdateOK
MediaWiki\Maintenance\MaintenanceFatalError: 

maintenance/includes/Maintenance.php:565
extensions/CommunityConfiguration/maintenance/UpdateEmergencyDefaults.php:57
vendor/wikimedia/testing-access-wrapper/src/TestingAccessWrapper.php:114
extensions/CommunityConfiguration/tests/phpunit/integration/maintenance/UpdateEmergencyDefaultsTest.php:53

This task is about making it possible to run CommunityConfiguration tests without CommunityConfigurationExample.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Zuul: [WP25EasterEggs] add CommunityConfigurationExample"integration/configmaster+0 -1
cypress: skip when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationREL1_45+16 -0
cypress: skip when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationREL1_44+16 -0
cypress: skip when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationREL1_43+16 -0
cypress: skip when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationmaster+16 -0
Zuul: [WP25EasterEggs] add CommunityConfigurationExampleintegration/configmaster+1 -0
Skip tests when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationmaster+9 -0
Skip tests when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationREL1_43+7 -0
Skip tests when CommunityConfigurationExample is not loadedmediawiki/extensions/CommunityConfigurationREL1_44+9 -0
Customize query in gerrit

Related Objects

Event Timeline

hashar created this task.Sep 18 2025, 6:07 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 18 2025, 6:07 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
hashar claimed this task.Sep 19 2025, 8:47 AM
gerritbot added a comment.Sep 19 2025, 8:50 AM

Change #1189797 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@master] Skip tests when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1189797

gerritbot added a project: Patch-For-Review.Sep 19 2025, 8:50 AM
gerritbot added a comment.Sep 19 2025, 11:35 AM

Change #1189797 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Skip tests when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1189797

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 19 2025, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Sep 19 2025, 12:31 PM
gerritbot added a comment.Sep 19 2025, 9:01 PM

Change #1189926 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@REL1_43] Skip tests when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1189926

gerritbot added a project: Patch-For-Review.Sep 19 2025, 9:01 PM
gerritbot added a comment.Sep 19 2025, 9:08 PM

Change #1189927 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@REL1_44] Skip tests when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1189927

gerritbot added a comment.Sep 22 2025, 11:40 AM

Change #1189927 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@REL1_44] Skip tests when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1189927

gerritbot added a comment.Sep 22 2025, 11:40 AM

Change #1189926 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@REL1_43] Skip tests when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1189926

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2025, 12:31 PM
hashar closed this task as Resolved.Sep 30 2025, 11:47 AM

This has been fixed and backported.

thcipriani added projects: Release-Engineering-Team (Doing 😎), Essential-Work.Oct 4 2025, 12:30 AM
hashar reopened this task as Open.Dec 8 2025, 3:32 PM

In my original run I did not take in account browser tests. The Cypress testsuite in CommunitConfiguration requires ConfigurationExample, they should be skipped when it is not present.

Example https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WP25EasterEggs/+/1214005 which depends on CommunityConfiguration and has recursion disabled:

zuul/dependencies.yaml
WP25EasterEggs:
  recurse: false
  dependencies:
    - CommunityConfiguration
    - Wikibase

And that leads to the failure:

Community Configuration Example Page
  1) should save configuration changes and verify them on the example page
  Form elements and basic functionality
    2) should have all expected form elements and labels
    3) should have a save button
    4) should have a disabled save button for logged-out users
    5) should update a simple string via API and verify the update on the form
Expected to find element: `#CCExample_String input[type="text"]`, but never found it.
Expected to find element: `#CCExample_String`, but never found it.
Expected to find content: '(communityconfiguration-editor-form-submit-button-text)' within the element: <button.cdx-button.cdx-search-input__end-button> but never did.
Expected to find content: '(communityconfiguration-editor-form-submit-button-text)' within the element: <button.cdx-button.cdx-search-input__end-button> but never did.
User "WikiAdmin": Action "communityconfigurationedit" returned error code "badvalue": Unrecognized value for parameter "provider": CommunityConfigurationExample.!

The Cypress tests should skip https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Cite/+/1213500

hashar added a comment.Dec 8 2025, 5:16 PM

I have tried to have the tests to be skipped in the before hook without using @cypress/skip-test since it is deprecated. I could not figure it out :-\ Thus I guess I should just add @cypress/skip-test. That will be for tomorrow.

hashar renamed this task from CommunityConfiguration uconditionally requires CommunityConfigurationExample to CommunityConfiguration unconditionally requires CommunityConfigurationExample.Dec 9 2025, 8:26 AM
hashar added a comment.Dec 9 2025, 9:05 AM

I have tried to have the tests skipped from the before hook using:

describe( 'Community Configuration Example Page', () => {

   before( () => {
        cy.visit( 'index.php?title=Special:CommunityConfiguration/CommunityConfigurationExample&uselang=qqx' );
        cy.contains( 'communityconfiguration-provider-not-found', { timeout: 0 } )
            .then( () => {
                cy.state( 'runnable' ).ctx.skip();
            } );
    } );

cy.state() is not part of the official API and the contains() assertion obviously fails when CommunityConfigurationExample is present which leads to all tests failing :]

gerritbot added a comment.Dec 9 2025, 9:41 AM

Change #1216756 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@master] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1216756

gerritbot added a project: Patch-For-Review.Dec 9 2025, 9:41 AM
gerritbot added a comment.Dec 9 2025, 9:50 AM

Change #1216759 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Zuul: [WP25EasterEggs] add CommunityConfigurationExample

https://gerrit.wikimedia.org/r/1216759

gerritbot added a comment.Dec 9 2025, 9:50 AM

Change #1216760 had a related patch set uploaded (by Hashar; author: Hashar):

[integration/config@master] Revert "Zuul: [WP25EasterEggs] add CommunityConfigurationExample"

https://gerrit.wikimedia.org/r/1216760

gerritbot added a comment.Dec 9 2025, 9:52 AM

Change #1216759 merged by jenkins-bot:

[integration/config@master] Zuul: [WP25EasterEggs] add CommunityConfigurationExample

https://gerrit.wikimedia.org/r/1216759

gerritbot added a comment.Dec 10 2025, 12:24 PM

Change #1217162 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@REL1_43] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1217162

gerritbot added a comment.Dec 10 2025, 12:24 PM

Change #1217163 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@REL1_44] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1217163

gerritbot added a comment.Dec 10 2025, 12:24 PM

Change #1217164 had a related patch set uploaded (by Hashar; author: Hashar):

[mediawiki/extensions/CommunityConfiguration@REL1_45] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1217164

gerritbot added a comment.Dec 10 2025, 12:41 PM

Change #1216756 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1216756

gerritbot added a comment.Dec 10 2025, 12:52 PM

Change #1217162 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@REL1_43] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1217162

gerritbot added a comment.Dec 10 2025, 12:52 PM

Change #1217163 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@REL1_44] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1217163

gerritbot added a comment.Dec 10 2025, 12:53 PM

Change #1217164 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@REL1_45] cypress: skip when CommunityConfigurationExample is not loaded

https://gerrit.wikimedia.org/r/1217164

gerritbot added a comment.Dec 10 2025, 12:57 PM

Change #1216760 merged by jenkins-bot:

[integration/config@master] Revert "Zuul: [WP25EasterEggs] add CommunityConfigurationExample"

https://gerrit.wikimedia.org/r/1216760

hashar closed this task as Resolved.Dec 10 2025, 12:58 PM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 10 2025, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Dec 10 2025, 1:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits