Page MenuHomePhabricator

Consider correcting the declared type of Z14K4
Closed, ResolvedPublic

Description

Description

Z14K4 is declared with type Z8, and yet all built-in implementation definitions specify the value as a string. Z8 is totally wrong because the builtins are in no way Z8s. Our code enforces by convention that this particular use of Z6 has special semantics. The convention is unambiguous, so there's no real danger with using Z6.

Changing the declared type to Z6 will increase Code consistency and comprehensibility. (However, the current state of affairs is not causing any bugs or brokenness.)

Another possibility to consider: Since Z14K1 already mentions the builtin function, Z14K4 could just be changed to a boolean.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • No change in behavior expected

Completion checklist

Event Timeline

DSantamaria changed the task status from Open to In Progress.Thu, Oct 1, 1:02 PM
DSantamaria added a project: Essential-Work.

Change #1347691 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5e0b049)

https://gerrit.wikimedia.org/r/1347691

Change #1347691 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Update function-schemata sub-module to HEAD (5e0b049)

https://gerrit.wikimedia.org/r/1347691

Change #1352518 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-09-30-134115 to 2026-10-07-130343

https://gerrit.wikimedia.org/r/1352518

Change #1352519 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-09-30-134715 to 2026-10-07-060824

https://gerrit.wikimedia.org/r/1352519

Change #1352518 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-09-30-134115 to 2026-10-07-130343

https://gerrit.wikimedia.org/r/1352518

Change #1352519 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2026-09-30-134715 to 2026-10-07-060824

https://gerrit.wikimedia.org/r/1352519