Page MenuHomePhabricator

Consider correcting the declared type of Z14K4
Open, LowPublic

Description

Description

Z14K4 is declared with type Z8, and yet all built-in implementation definitions specify the value as a string. Z8 is totally wrong because the builtins are in no way Z8s. Our code enforces by convention that this particular use of Z6 has special semantics. The convention is unambiguous, so there's no real danger with using Z6.

Changing the declared type to Z6 will increase Code consistency and comprehensibility. (However, the current state of affairs is not causing any bugs or brokenness.)

Another possibility to consider: Since Z14K1 already mentions the builtin function, Z14K4 could just be changed to a boolean.

Desired behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • No change in behavior expected

Completion checklist