Page MenuHomePhabricator

Dialog: optimize mobile version in Codex
Closed, ResolvedPublic

Assigned To
Authored By
DTorsani-WMF
Sep 18 2025, 5:44 PM
Referenced Files
F66056048: image.png
Sep 18 2025, 5:44 PM
F66056046: image.png
Sep 18 2025, 5:44 PM
F66056044: image.png
Sep 18 2025, 5:44 PM
F66056042: image.png
Sep 18 2025, 5:44 PM

Description

Background

To build in more native responsiveness into Codex components as a part of T404968: [EPIC] Component responsiveness, we want to redesign the mobile Dialog.

One primary concern discussed in T321893: Dialog: Evaluate fullscreen on mobile was the location of actions, and how they behave when a keyboard appears. Based on the user testing research found in T339369: Component user testing: conduct pilot testing on Fullscreen Mobile Dialogs the fixed buttons on the bottom were not found to be problematic. Users did not have trouble getting back to them after completing typing. They found the overall location more accessible.

Design drafts

General design details
Default mobile Dialog

image.png (584×336 px, 21 KB)

Dialog fixed header and footer

When the content becomes longer than the height of the Dialog, the bottom actions become contained in a fixed container with a border on top to separate from the text within the body of the Dialog (which is the current behavior).

The same treatment is true for the header container when the content is longer than the height of the Dialog and the Dialog is being scrolled, with the border being on the bottom of said container.

There should not be any shadows for these fixed containers.

image.png (584×336 px, 45 KB)

image.png (584×336 px, 45 KB)

Dialog with keyboard overtop

When a keyboard appears, it should appear overtop the Dialog, not moving any actions.

image.png (584×336 px, 143 KB)

Event Timeline

DTorsani-WMF removed DTorsani-WMF as the assignee of this task.
DTorsani-WMF triaged this task as Medium priority.
DTorsani-WMF moved this task from Backlog to Ready for Design/Dev on the Codex board.

Just to confirm currently the dialog is not full screen when in mobile right. I should make it full screen in case of Mobile. I was not able to see that it was full screen in Mobile currently.

@Gauthammohanraj that's correct. The mobile Dialog should be full screen, without any page padding or overlay. The Dialog shadow and border should be removed, as it should be flush against the edge of the window. Please let me know if you have any other questions, and thanks for working on this!

Change #1197051 had a related patch set uploaded (by Gauthammohanraj; author: Gauthammohanraj):

[design/codex@main] Dialog: Make Dialog Full Screen for Mobile devices

https://gerrit.wikimedia.org/r/1197051

@Gauthammohanraj just curious if you've been able to work on this anymore? Or if you would like to?

I got a little busy in between. I will make changes to my existing MR soon.

Gauthammohanraj updated Other Assignee, added: Gauthammohanraj.

I would be unassigning myself for now as I am not sure If I will be able to continue working on this issue

Okay, thanks for the update and your work thus far @Gauthammohanraj. @Catrope can you pick this up and push it over the finish line, along with the mobile Popover?

Change #1197051 merged by jenkins-bot:

[design/codex@main] Dialog: Make Dialog full screen on small screens

https://gerrit.wikimedia.org/r/1197051

Change #1211730 had a related patch set uploaded (by Catrope; author: Catrope):

[mediawiki/core@master] Update Codex from v2.3.2 to v2.3.3

https://gerrit.wikimedia.org/r/1211730

Test wiki created on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task:
https://ebaf825438.catalyst.wmcloud.org/w/

Change #1211730 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.3.2 to v2.3.3

https://gerrit.wikimedia.org/r/1211730

Catrope claimed this task.

Test wiki on Patch demo by Roan Kattouw (WMF) using patch(es) linked to this task was deleted:

https://ebaf825438.catalyst.wmcloud.org/w/