Upgrade of api-testing from 1.7.0 to 1.7.1 in Wikibase extension gives failure "Object prototype may only be an Object or null: undefined"
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	Sep 18 2025, 6:44 PM

Description

The update of api-testing on Wikibase extension has error from api-testing, that seems related to the new version.

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1179238
https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php81-selenium/32851/console

22:07:44   1) An uncaught error was detected outside of a test:
22:07:44      TypeError: The following error originated from your test code, not from Cypress.
22:07:44 
22:07:44   > Object prototype may only be an Object or null: undefined
22:07:44 
22:07:44 When Cypress detects uncaught errors originating from your test code it will automatically fail the current test.
22:07:44 
22:07:44 Cypress could not associate this error to any specific test.
22:07:44 
22:07:44 We dynamically generated a new test to display this failure.
22:07:44       at Function.setPrototypeOf (<anonymous>)
22:07:44       at ./node_modules/supertest/lib/agent.js (webpack://wikibase/./node_modules/supertest/lib/agent.js:53:0)
22:07:44       at __webpack_require__ (webpack://wikibase/webpack/bootstrap:19:0)
22:07:44       at ./node_modules/supertest/index.js (webpack://wikibase/./node_modules/supertest/index.js:14:14)
22:07:44       at __webpack_require__ (webpack://wikibase/webpack/bootstrap:19:0)
22:07:44       at ./node_modules/api-testing/lib/actionapi.js (webpack://wikibase/./node_modules/api-testing/lib/actionapi.js:4:18)
22:07:44       at __webpack_require__ (webpack://wikibase/webpack/bootstrap:19:0)
22:07:44       at ./node_modules/api-testing/lib/action_clients.js (webpack://wikibase/./node_modules/api-testing/lib/action_clients.js:4:15)
22:07:44       at __webpack_require__ (webpack://wikibase/webpack/bootstrap:19:0)
22:07:44       at ./node_modules/api-testing/index.js (webpack://wikibase/./node_modules/api-testing/index.js:4:9)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Upgrade api-testing to 1.7.2	mediawiki/extensions/Wikibase	master	+226 -79
	Update supertest to 7.2.2	mediawiki/tools/api-testing	master	+42 -22

Customize query in gerrit

Related Objects

Mentioned In: rMTAT7e689500f15b: Export the config module in index.json
rMTAT022842171584: Update supertest to 7.2.2
Mentioned Here: T372465: Make it possible to opt out of LibUp automatic .eslintrc.json edits
T391763: Libup fails with "ValueError: Did not find eslint config for /src/repo/client/resources/jquery.ui/jquery.ui.suggester.js!" on Wikibase

Event Timeline

Umherirrender created this task.Sep 18 2025, 6:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 18 2025, 6:44 PM

karapayneWMDE added a project: Wikibase Reuse Team.Sep 19 2025, 8:15 AM

WMDE-leszek edited projects, added Wikidata-Omega; removed Wikibase Reuse Team.Sep 19 2025, 8:33 AM

I believe that’s the same issue as supertest#867 / superagent#1840 – I don’t remember if there was already a Phabricator task for it, though it was mentioned in the commit message of the change introducing these tests. @ArthurTaylor proposed a fix upstream at superagent#1839, but there’s been no response so far.

Umherirrender renamed this task from Upgrade api-testing 1.7.0 → 1.7.1 in Wikibase extension has failure Object prototype may only be an Object or null: undefined to Upgrade of api-testing from 1.7.0 to 1.7.1 in Wikibase extension gives failure "Object prototype may only be an Object or null: undefined".Sep 22 2025, 6:39 PM

Umherirrender unsubscribed.

karapayneWMDE moved this task from Incoming to Radar/Epics/Stalled on the Wikidata-Omega board.Oct 21 2025, 5:00 PM

karapayneWMDE edited projects, added Wikidata-Omega (Radar/Epics/Stalled); removed Wikidata-Omega.

karapayneWMDE moved this task from Incoming to Radar on the Wikidata-Omega (Radar/Epics/Stalled) board.

Still happening, e.g. on this LibUp change. After four months of no response on the upstream issue or pull request (and little other activity on the linked repo either), maybe we should reconsider the use of supertest/superagent in api-testing…

(Also trying a new tag given that Core Platform Team Initiatives (API Integration Tests) is archived.)

aaron triaged this task as Low priority.Dec 17 2025, 5:47 PM

aaron moved this task from Incoming (Needs Triage) to Bugs & Chores on the MW-Interfaces-Team board.

Looks like forwardemail have merged the fix and released the updated versions: https://github.com/forwardemail/superagent/releases/tag/v10.3.0 and https://github.com/forwardemail/supertest/releases/tag/v7.2.0 .

karapayneWMDE moved this task from Radar/Epics/Stalled to The Backlog on the Wikidata-Omega board.Jan 6 2026, 10:03 AM

karapayneWMDE edited projects, added Wikidata-Omega; removed Wikidata-Omega (Radar/Epics/Stalled).

AudreyPenven_WMDE claimed this task.Jan 6 2026, 4:48 PM

AudreyPenven_WMDE moved this task from The Backlog to The Board on the Wikidata-Omega board.

AudreyPenven_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

AudreyPenven_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

In T405027#11446347, @Lucas_Werkmeister_WMDE wrote:

Still happening, e.g. on this LibUp change.

Looks like WikibaseQualityConstraints will also need a manual version bump, LibUp seemingly isn’t picking up the new superagent+supertest versions automatically.

Change #1224690 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/tools/api-testing@master] Update supertest to 7.2.2

https://gerrit.wikimedia.org/r/1224690

gerritbot added a project: Patch-For-Review.Jan 8 2026, 2:38 PM

Change #1224690 merged by jenkins-bot:

[mediawiki/tools/api-testing@master] Update supertest to 7.2.2

https://gerrit.wikimedia.org/r/1224690

AudreyPenven_WMDE mentioned this in rMTAT022842171584: Update supertest to 7.2.2.Jan 8 2026, 3:18 PM

The current version of api-testing locks supertest at "7.1.0", which I assume is why LibUp could not update it.
A patch to bump the dependency in api-testing is merged, but we'll need a new release of that before it is available.

This patch updates the version: https://gerrit.wikimedia.org/r/c/mediawiki/tools/api-testing/+/1224717
Someone with the right permissions in npm will need to do the release.

And then I think we need an update to LibUp’s config so it’ll start to push out the new version everywhere. (We’ll need to do Wikibase manually, but e.g. WikibaseQualityConstraints can hopefully be done by LibUp.)

LibUp's config was updated yesterday, so now I'm confused about a couple things:

Wikibase is one of the repos monitored by LibUp. Why does it need to be done manually? Is it because the last attempt to update (to api-testing, v1.7.1) failed?
If we expect WikibaseQualityConstraints to be done by LibUp, why hasn't it been done yet? If I'm reading it right, the logs from its run this morning do not include updating api-testing to 1.7.2.

In T405027#11507591, @AudreyPenven_WMDE wrote:

LibUp's config was updated yesterday, so now I'm confused about a couple things:

Wikibase is one of the repos monitored by LibUp. Why does it need to be done manually? Is it because the last attempt to update (to api-testing, v1.7.1) failed?

LibUp insists on being able to update eslint config to automatically ignore any failing rules, and Wikibase’s non-JSON config breaks that: T391763, T372465. So LibUp generally doesn’t work for Wikibase.

If we expect WikibaseQualityConstraints to be done by LibUp, why hasn't it been done yet? If I'm reading it right, the logs from its run this morning do not include updating api-testing to 1.7.2.

I was also unsure about that; I think it might be because, according to its status page, api-testing 1.7.2 is still in the “canary” stage?

(Even though the VisualEditor change has in fact been merged successfully – maybe LibUp will only refresh its information on its next daily(?) run.)

Change #1224971 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] Upgrade api-testing to 1.7.2

https://gerrit.wikimedia.org/r/1224971

Although, looking at the change you linked in the commit message there – maybe we can try to let LibUp upgrade Wikibase after all, and it’ll work as long as it doesn’t have to touch the eslint config? (I wasn’t aware that change existed – looks like LibUp+Wikibase isn’t quite as broken as I thought.)

Should we just wait and see what LibUp does in its next run then?

Yeah, that sounds okay to me.

Ahhh maybe not. A test failure on CI lead me to this commit in api-testing, which makes the config into a module object rather than a function.

in extensions/Wikibase/repo/domains/crud/tests/mocha/api-testing/AbuseFilterTest.js, it is assumed that this config is a function:

const config = require( 'api-testing/lib/config' )();

I see… then let’s do a manual upgrade that adjusts this code as needed, yeah. (Hopefully it’s still possible to access the config somewhere…)

Change #1224971 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Upgrade api-testing to 1.7.2

https://gerrit.wikimedia.org/r/1224971

In WikibaseQualityConstraints the upgrade was successful \o/

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikibaseQualityConstraints/+/1216884

I think we can move this to verification then?

hooray! moving it along now

mahmoud.abdelsattar.wmde claimed this task.Jan 22 2026, 12:54 PM

mahmoud.abdelsattar.wmde moved this task from Ready for Tech Verification to In Tech Verification on the Wikidata-Omega (The Board) board.

mahmoud.abdelsattar.wmde removed mahmoud.abdelsattar.wmde as the assignee of this task.Jan 23 2026, 4:15 PM

mahmoud.abdelsattar.wmde moved this task from In Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

mahmoud.abdelsattar.wmde subscribed.

Jdforrester-WMF added a project: api-testing-tool.Feb 5 2026, 4:02 PM

karapayneWMDE closed this task as Resolved.Mon, Feb 9, 8:50 AM

karapayneWMDE claimed this task.

karapayneWMDE moved this task from Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move to Ready for Tech Verification on the Wikidata-Omega (The Board) board.

karapayneWMDE moved this task from Ready for Tech Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).

jenkins-bot mentioned this in rMTAT7e689500f15b: Export the config module in index.json.Tue, Feb 10, 2:24 PM

karapayneWMDE moved this task from Newly completed tasks to 2026 Q1 on the Wikidata-Omega (Completed Tasks) board.Tue, Feb 10, 5:02 PM

	F71481140: image.png
	Jan 9 2026, 2:22 PM

Upgrade of api-testing from 1.7.0 to 1.7.1 in Wikibase extension gives failure "Object prototype may only be an Object or null: undefined"Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

Upgrade of api-testing from 1.7.0 to 1.7.1 in Wikibase extension gives failure "Object prototype may only be an Object or null: undefined"
Closed, ResolvedPublic
Actions