Page MenuHomePhabricator
Create Task
Maniphest T405106

Featured templates display in random order instead of configured order
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Samwilson
Authored By
Boro
Sep 19 2025, 1:46 PM
Tags
Referenced Files
F71131650: 2025-12-18_16-11-12.webm
Dec 19 2025, 12:18 AM
F71131647: 2025-12-18_16-10-19.webm
Dec 19 2025, 12:18 AM
F71131640: 2025-12-18_16-09-18.webm
Dec 19 2025, 12:18 AM
F71131628: 2025-12-18_16-06-20.webm
Dec 19 2025, 12:18 AM
F71084758: 2025-12-15_15-08-13.webm
Dec 15 2025, 11:18 PM
F71084776: 2025-12-15_15-13-25.webm
Dec 15 2025, 11:18 PM
F71084811: 2025-12-15_12-18-46.png
Dec 15 2025, 11:18 PM
F71084747: 2025-12-15_15-11-34.png
Dec 15 2025, 11:18 PM
View All 10 Files
Subscribers
Aklapper
Boro
GMikesell-WMF
Johannnes89
Samwilson

Description

Steps to replicate the issue

  • Set featured templates using Special:CommunityConfiguration/TemplateData-FeaturedTemplates
  • Templates are listed in the desired order, both on this page and in MediaWiki:FeaturedTemplates.json
  • Open the Template Wizard (either in VisualEditor or source editor), then go to the Featured tab
  • Tab displays the templates in a random order and the order changes after each page refresh

What happens?:
Featured templates are displayed in a random order in the Template Wizard

What should have happened instead?:
Featured templates are displayed in the order as they were defined in the JSON

Software version: 1.45.0-wmf.19

Affected wikis:

Derived Requirement

Ensure that featured templates displayed in the Template Wizard are shown in the exact order defined in MediaWiki:FeaturedTemplates.json.
The display order must be deterministic and consistent across page loads, editor modes (VisualEditor and source editor), and refreshes.
This requirement is derived from the expected behavior described in *“What should have happened instead?”*.

Test Result - Beta|Prod

Status: ✅ PASS / ❓Need More Info / ❌ FAIL
Environment: beta/enwiki
OS: macOS Tahoe 26.1
Browser: Chrome 142
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify featured templates display in configured order in VisualEditor

Preconditions:

  • Featured templates are configured via *Special:CommunityConfiguration/TemplateData-FeaturedTemplates*.
  • MediaWiki:FeaturedTemplates.json contains templates in a known, explicit order.
  1. Navigate to *Special:CommunityConfiguration/TemplateData-FeaturedTemplates*.
  2. Confirm the order of templates as listed and as stored in MediaWiki:FeaturedTemplates.json.
  3. Open any article in VisualEditor.
  4. Open the Template Wizard.
  5. Select the Featured tab.
  6. ✅❓❌⬜ AC1: Confirm featured templates are displayed in the same order as defined in MediaWiki:FeaturedTemplates.json.

Test Case 2: Verify featured templates order remains consistent after page refresh

  1. With the Template Wizard still open on the Featured tab, refresh the page.
  2. Reopen the Template Wizard and navigate back to the Featured tab.
  3. ✅❓❌⬜ AC2: Confirm the order of featured templates remains unchanged after refresh.

Test Case 3: Verify featured templates display in configured order in source editor

  1. Open an article using the source editor.
  2. Launch the Template Wizard.
  3. Navigate to the Featured tab.
  4. ✅❓❌⬜ AC3: Confirm featured templates are displayed in the same configured order as defined in the JSON.

QA Results -PROD

ACStatusDetails
1✅T405106#11474883
2✅T405106#11474883
3✅T405106#11474883

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Featured templates: re-order according to original ordermediawiki/extensions/TemplateDatamaster+10 -4
Fetch info of all featured templates at oncemediawiki/extensions/TemplateDatamaster+19 -21
Customize query in gerrit

Related Objects

Event Timeline

Boro created this task.Sep 19 2025, 1:46 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 19 2025, 1:46 PM
Maintenance_bot added a project: VisualEditor.Sep 19 2025, 2:29 PM
A_smart_kitten added a project: Template-Discovery-And-Recall.Sep 19 2025, 4:22 PM
Restricted Application added a project: Community-Tech. · View Herald TranscriptSep 19 2025, 4:22 PM
Johannnes89 subscribed.Sep 19 2025, 9:16 PM
Samwilson claimed this task.Sep 20 2025, 2:23 AM
Samwilson edited projects, added Community-Tech (Fox Squad); removed Community-Tech.
Samwilson subscribed.

The API is returning them in the same order: https://fr.wikipedia.org/w/api.php?action=query&format=json&meta=communityconfiguration&formatversion=2&ccrprovider=TemplateData-FeaturedTemplates&ccrassertversion=1.0.0

It looks like the error is that after retrieving that list we then make separate requests for each template's details, and those requests can come back out of order.

I'll fix this up.

Samwilson moved this task from Ready for Dev to In Development on the Community-Tech (Fox Squad) board.Sep 20 2025, 2:23 AM
gerritbot added a comment.Sep 20 2025, 6:18 AM

Change #1189948 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Fetch info of all featured templates at once

https://gerrit.wikimedia.org/r/1189948

gerritbot added a project: Patch-For-Review.Sep 20 2025, 6:18 AM
Samwilson moved this task from New & TBD Tickets to Featured templates on the Template-Discovery-And-Recall board.Sep 21 2025, 7:58 AM
Samwilson moved this task from In Development to Feedback and Review on the Community-Tech (Fox Squad) board.Sep 22 2025, 5:05 AM
gerritbot added a comment.Sep 22 2025, 3:22 PM

Change #1189948 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Fetch info of all featured templates at once

https://gerrit.wikimedia.org/r/1189948

Maintenance_bot removed a project: Patch-For-Review.Sep 22 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.20; 2025-09-23).Sep 22 2025, 4:03 PM
Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Sep 22 2025, 9:09 PM
Boro awarded a token.Sep 23 2025, 4:51 AM
Boro added a comment.Oct 17 2025, 8:37 PM

If I understand correctly, this change was merged and released, but the issue still persists on the de, nl, and hu wikis. On frwiki, however, it appears to respect the configured order now.

gerritbot added a comment.Oct 17 2025, 11:46 PM

Change #1196987 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TemplateData@master] Featured templates: re-order according to original order

https://gerrit.wikimedia.org/r/1196987

gerritbot added a project: Patch-For-Review.Oct 17 2025, 11:46 PM
Samwilson moved this task from QA to Feedback and Review on the Community-Tech (Fox Squad) board.Oct 17 2025, 11:51 PM

Yes it looks like the frwiki case is a fluke of the desired order happening to match up with the page ID order of those templates! Oops. Sorry about this. Thanks for checking up on it!

I've made a fix that re-orders the action=templatedata API results to be in the same order as the original template titles that get retrieved from CommunityConfiguration.

Boro added a comment.Oct 18 2025, 10:54 AM

No worries, thanks for the quick turnaround! :)

gerritbot added a comment.Dec 11 2025, 10:46 AM

Change #1196987 merged by jenkins-bot:

[mediawiki/extensions/TemplateData@master] Featured templates: re-order according to original order

https://gerrit.wikimedia.org/r/1196987

Samwilson moved this task from Feedback and Review to QA on the Community-Tech (Fox Squad) board.Dec 11 2025, 10:56 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.7; 2025-12-16).Dec 11 2025, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 11 2025, 11:30 AM
GMikesell-WMF updated the task description. (Show Details)Dec 15 2025, 11:06 PM
GMikesell-WMF updated Other Assignee, added: GMikesell-WMF.
GMikesell-WMF subscribed.Dec 15 2025, 11:18 PM

@Samwilson Do you know why I'm not seeing anything in the features tab like I was with Deutsch?

Test Result - Beta

Status: ❌ FAIL
Environment: Beta: 1.46.0-alpha (ebc6935) 16:02, 15 December 2025
OS: macOS Tahoe 26.1
Browser: Chrome 142
Device: MBA
Emulated Device: NA

Test Artifact(s):
https://en.wikipedia.beta.wmcloud.org/wiki/Bat-eared_fox
https://en.wikipedia.beta.wmcloud.org/wiki/Special:CommunityConfiguration/TemplateData-FeaturedTemplates
https://en.wikipedia.beta.wmcloud.org/wiki/MediaWiki:FeaturedTemplates.json

Test Steps

Test Case 1: Verify featured templates display in configured order in VisualEditor

Preconditions:

  • Featured templates are configured via *Special:CommunityConfiguration/TemplateData-FeaturedTemplates*.
  • MediaWiki:FeaturedTemplates.json contains templates in a known, explicit order.
  1. Navigate to *Special:CommunityConfiguration/TemplateData-FeaturedTemplates*.
  2. Confirm the order of templates as listed and as stored in MediaWiki:FeaturedTemplates.json.
  3. Open any article in VisualEditor.
  4. Open the Template Wizard.
  5. Select the Featured tab.
  6. ❌ AC1: Confirm featured templates are displayed in the same order as defined in MediaWiki:FeaturedTemplates.json.
VisualEditorSpecial:CommunityConfigurationMediaWiki:FeaturedTemplates.jsonDeutsch
2025-12-15_15-11-41.png (1×1 px, 284 KB)
2025-12-15_15-11-34.png (1×1 px, 180 KB)
2025-12-15_12-18-46.png (1×1 px, 299 KB)

Test Case 2: Verify featured templates order remains consistent after page refresh

  1. With the Template Wizard still open on the Featured tab, refresh the page.
  2. Reopen the Template Wizard and navigate back to the Featured tab.
  3. ❌ AC2: Confirm the order of featured templates remains unchanged after refresh.

Test Case 3: Verify featured templates display in configured order in source editor

  1. Open an article using the source editor.
  2. Launch the Template Wizard.
  3. Navigate to the Featured tab.
  4. ❌AC3:** Confirm featured templates are displayed in the same configured order as defined in the JSON.

GMikesell-WMF changed the task status from Open to In Progress.Dec 15 2025, 11:19 PM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF moved this task from QA to In Development on the Community-Tech (Fox Squad) board.
Samwilson moved this task from In Development to QA on the Community-Tech (Fox Squad) board.Dec 16 2025, 1:22 AM

Sorry @GMikesell-WMF this hasn't yet been deployed to production! So it's not on de.wikipedia.org yet. It'll go out on this week's train (i.e. will be on all wikis by 2025-12-18 19:00 UTC).

If you're happy with how it's working on Beta, that's probably good enough.

GMikesell-WMF added a comment.Dec 19 2025, 12:18 AM

@Samwilson Confirmed that the featured templates display in the configured order, as seen in the videos below. I will mark this as Resolved. Thanks for all your work!

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Tahoe 26.1
Browser: Chrome 143
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Verify featured templates display in configured order in VisualEditor

Preconditions:

  • Featured templates are configured via *Special:CommunityConfiguration/TemplateData-FeaturedTemplates*.
  • MediaWiki:FeaturedTemplates.json contains templates in a known, explicit order.
  1. Navigate to *Special:CommunityConfiguration/TemplateData-FeaturedTemplates*.
  2. Confirm the order of templates as listed and as stored in MediaWiki:FeaturedTemplates.json.
  3. Open any article in VisualEditor.
  4. Open the Template Wizard.
  5. Select the Featured tab.
  6. ✅ AC1: Confirm featured templates are displayed in the same order as defined in MediaWiki:FeaturedTemplates.json.
defrnlhu

Test Case 2: Verify featured templates order remains consistent after page refresh

  1. With the Template Wizard still open on the Featured tab, refresh the page.
  2. Reopen the Template Wizard and navigate back to the Featured tab.
  3. ✅ AC2: Confirm the order of featured templates remains unchanged after refresh.

See AC1

Test Case 3: Verify featured templates display in configured order in source editor

  1. Open an article using the source editor.
  2. Launch the Template Wizard.
  3. Navigate to the Featured tab.
  4. ✅AC3:** Confirm featured templates are displayed in the same configured order as defined in the JSON.

See AC1

GMikesell-WMF closed this task as Resolved.Dec 19 2025, 12:19 AM
GMikesell-WMF updated the task description. (Show Details)
GMikesell-WMF updated Other Assignee, removed: GMikesell-WMF.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits