Page MenuHomePhabricator

Update convenientDiscussions.js MobileFrontend detect for unified mobile routing
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Other information (browser name/version, screenshots, etc.):

See also https://www.mediawiki.org/wiki/Requests_for_comment/Mobile_domain_sunsetting/2025_Announcement

I was able to find this proactively via the Global Search tool, thanks to the older non-obfuscated copy at https://www.mediawiki.org/wiki/User:Jack_who_built_the_house/convenientDiscussions.js:

if (!location.host.endsWith(".m.wikipedia.org")

The latest release is at https://commons.wikimedia.org/wiki/User:Jack_who_built_the_house/convenientDiscussions.js, but I would not have found that.

It looks like the latest source still has similar code:
https://github.com/jwbth/convenient-discussions/blob/v7.6.13/src/app.js#L305

if (
  /(^|\.)m\./.test(location.hostname) ||
  mw.config.get('wgPageContentModel') !== 'wikitext' ||
  mw.config.get('wgIsMainPage')
) {
  return;
}

Event Timeline

Krinkle renamed this task from Update MobileFrontent detect for unified mobile routing to Update convenientDiscussions.js MobileFrontend detect for unified mobile routing.

https://github.com/jwbth/convenient-discussions/pull/99

src/app.js
    if (
-       /(^|\.)m\./.test(location.hostname) ||
+       mw.config.get('wgMFMode') ||
Jack_who_built_the_house assigned this task to Krinkle.

This one I overlooked, big thanks! It's live.