Page MenuHomePhabricator

CodeMirror styles prevent Codex dialogs from rendering after VE edits
Closed, ResolvedPublicBUG REPORT

Description

In r1182656 for T400953, I'm adding a Codex dialog that is displayed after edits (code). This works with the source editor, but not with VE. Upon closer inspection, I can see that the dialog is mounted, and displayed, but it is completely invisible due to the following CSS rule:

.cdx-dialog-backdrop {
    opacity: 0;
}

This is coming from codemirror.less. The rule is problematic because it styles elements it doesn't own, therefore breaking functionality for other Codex user on the same page. I still haven't looked into what the rule is trying to achieve, but if it is needed, I believe it should find a way to target the intended element only.

Event Timeline

Change #1189947 had a related patch set uploaded (by Bhsd; author: Bhsd):

[mediawiki/extensions/CodeMirror@master] CodeMirrorCodex: do not break the Codex styles

https://gerrit.wikimedia.org/r/1189947

MusikAnimal changed the task status from Open to In Progress.Sep 20 2025, 9:53 PM
MusikAnimal assigned this task to Bhsd.
MusikAnimal subscribed.

Sorry about that! I've just merged the above patch which should fix it. (Thanks Bhsd!)

MusikAnimal changed the subtype of this task from "Task" to "Bug Report".

Change #1189947 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirrorCodex: do not break the Codex styles

https://gerrit.wikimedia.org/r/1189947

ifried subscribed.

@MusikAnimal, we're thinking of closing this task as resolved. Any objections?

MusikAnimal moved this task from Bugs to Done on the MediaWiki-extensions-CodeMirror board.

For CodeMirror, we typically wait until a change is live before closing the task. This change is live now on some wikis. There aren't really users waiting for this to arrive to the other wikis, so yes, given you're the only real stakeholder and you're happy, then we're happy, and thus we can close :)