[MEX] M3.3.2 - editing snaks on references
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	karapayneWMDE
	Sep 22 2025, 2:58 PM

Description

As a contributor, i want to be able to edit references and snaks, so i can provide verifiable sources for statements.

Displaying references and snaks on the edit screen:

Screenshot 2025-10-10 at 11.26.42.png (1×1 px, 123 KB)

Figma for display of references and snaks

Adding snaks

Screenshot 2025-10-10 at 11.28.06.png (1×1 px, 189 KB)

Figma file for adding snaks

Deleting references or snaks

Screenshot 2025-10-10 at 11.28.38.png (852×1 px, 157 KB)

Figma file for deletion

Error handling

When a field is incomplete/incorrect, it should display there is an error (desktop behavior)
NEW: Should it be a simple input string, and nothing is written inside, once it is out of focus/ the user moves on from the field, it should also become red/error state. This is not currently implemented on desktop.

Screenshot 2025-09-29 at 17.04.32.png (1×1 px, 156 KB)

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Allow adding new snaks to references	mediawiki/extensions/Wikibase	master	+848 -155
	Edit and delete snaks on references	mediawiki/extensions/Wikibase	master	+870 -189

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T394621 [MEX] Mobile Editing Experience of Items Project
Open	None	T400128 [MEX] M3 - Create editing functionality for statements on Items on mobile
Resolved	Arian_Bozorg	T402618 [MEX] M3.3 edit functionality for qualifiers, references, and ranking
Resolved	Arian_Bozorg	T402433 [MEX] M3.3.2 - add references edit form to edit statements
Resolved	Arian_Bozorg	T405236 [MEX] M3.3.2 - editing snaks on references

Event Timeline

karapayneWMDE created this task.Sep 22 2025, 2:58 PM

Alice.moutinho updated the task description. (Show Details)Sep 22 2025, 3:31 PM

Alice.moutinho updated the task description. (Show Details)Sep 22 2025, 3:34 PM

Alice.moutinho updated the task description. (Show Details)Sep 22 2025, 3:41 PM

Alice.moutinho updated the task description. (Show Details)Sep 22 2025, 3:51 PM

karapayneWMDE moved this task from Incoming to Ready for Task Time (Story Writing) on the Wikidata-Omega board.Sep 24 2025, 1:20 PM

Arian_Bozorg assigned this task to Alice.moutinho.Sep 29 2025, 10:55 AM

Alice.moutinho updated the task description. (Show Details)Sep 29 2025, 3:01 PM

Alice.moutinho removed Alice.moutinho as the assignee of this task.Sep 29 2025, 3:06 PM

Alice.moutinho updated the task description. (Show Details)

Alice.moutinho moved this task from Ready for Task Time (Story Writing) to The Backlog on the Wikidata-Omega board.Sep 29 2025, 3:08 PM

AudreyPenven_WMDE claimed this task.Oct 6 2025, 4:27 PM

AudreyPenven_WMDE moved this task from The Backlog to The Board on the Wikidata-Omega board.

AudreyPenven_WMDE edited projects, added Wikidata-Omega (The Board); removed Wikidata-Omega.

AudreyPenven_WMDE moved this task from new to the board to In Development on the Wikidata-Omega (The Board) board.

@AudreyPenven_WMDE hey i just swaped the images and corrected the figma files: i had forgotten the snak type editing option in the fields. Is this something we can still mend in this ticket or was i too late (and we should make another ticket to add the snak type selection later)?

@Alice.moutinho all good! I haven't gotten very far with this yet, so it's fine to include it in this ticket.

Change #1194628 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] [WIP] edit snaks on references

https://gerrit.wikimedia.org/r/1194628

gerritbot added a project: Patch-For-Review.Oct 10 2025, 2:57 PM

Lucas_Werkmeister_WMDE renamed this task from [MEX] 3.3.2 - editing snaks on references to [MEX] M3.3.2 - editing snaks on references.Oct 21 2025, 9:03 AM

mahmoud.abdelsattar.wmde claimed this task.Oct 28 2025, 8:56 AM

mahmoud.abdelsattar.wmde moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

mahmoud.abdelsattar.wmde moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

🔄 Peer Review Handover Summary

Moved from "In Peer Review" > "In Development" due minor code review comments.

✅ Work Completed

The acceptance criteria are almost met regarding the proposed development with local manual testing .. looks promising so far (still missing only the error handling logic).

🧪 Testing/Technical Status

Completed:

E2E tests written and passing
Manual testing performed
CI Builds are green and no merge conflicts (so far)
Code review received

🚧 Remaining Work

Medium Priority:

The mentioned review comments must be addressed and resolved.
Only one note on the errors handling (missing implementation .. included in the comment reviews).

🔗 Related Resources

Related Gerrit Patch(s):

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/1194628

Handover Date: 30th October 2025
Last Updated By: Mahmoud

@Alice.moutinho @Arian_Bozorg I'm not sure about the Error Handling part .. is it an AC part of this ticket implementation? Or it should be general validation + error handling ticket?

@mahmoud.abdelsattar.wmde that is a good question... what do you think @karapayneWMDE?

AudreyPenven_WMDE moved this task from Ready for Development to In Development on the Wikidata-Omega (The Board) board.Oct 31 2025, 9:17 AM

Change #1194628 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Edit and delete snaks on references

https://gerrit.wikimedia.org/r/1194628

Maintenance_bot removed a project: Patch-For-Review.Oct 31 2025, 3:30 PM

I created a general error handling ticket here: T408928

AudreyPenven_WMDE removed AudreyPenven_WMDE as the assignee of this task.Nov 21 2025, 6:16 PM

AudreyPenven_WMDE moved this task from In Development to Ready for Peer Review on the Wikidata-Omega (The Board) board.

I’m not sure why this task is in Ready to Peer Review again, since all attached changes are merged… is Allow adding new snaks to references supposed to be attached to this task?

ArthurTaylor claimed this task.Nov 25 2025, 1:20 PM

ArthurTaylor removed ArthurTaylor as the assignee of this task.

ArthurTaylor moved this task from Ready for Peer Review to In Peer Review on the Wikidata-Omega (The Board) board.

ArthurTaylor moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.

ArthurTaylor moved this task from Product Verification to In Peer Review on the Wikidata-Omega (The Board) board.Nov 25 2025, 1:23 PM

oops, yeah, that should be attached. I'll fix the commit message

ArthurTaylor assigned this task to Lucas_Werkmeister_WMDE.Nov 25 2025, 1:27 PM

Change #1200100 had a related patch set uploaded (by Audrey Penven; author: Audrey Penven):

[mediawiki/extensions/Wikibase@master] Allow adding new snaks to references

https://gerrit.wikimedia.org/r/1200100

gerritbot added a project: Patch-For-Review.Nov 25 2025, 1:27 PM

Change #1200100 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Allow adding new snaks to references

https://gerrit.wikimedia.org/r/1200100

Maintenance_bot removed a project: Patch-For-Review.Dec 1 2025, 12:30 PM

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Dec 1 2025, 3:52 PM

Lucas_Werkmeister_WMDE moved this task from In Peer Review to Product Verification on the Wikidata-Omega (The Board) board.

Arian_Bozorg closed this task as Resolved.Dec 16 2025, 3:16 PM

Arian_Bozorg claimed this task.

Arian_Bozorg moved this task from Product Verification to Done - Moving a task here will move it to the completed tasks workboard, resolve the ticket, and assign it to whomever made the move on the Wikidata-Omega (The Board) board.

karapayneWMDE edited projects, added Wikidata-Omega (Completed Tasks); removed Wikidata-Omega (The Board).Tue, Feb 10, 5:11 PM

karapayneWMDE moved this task from Newly completed tasks to 2025 Q4 on the Wikidata-Omega (Completed Tasks) board.

	F66740874: Screenshot 2025-10-10 at 11.28.38.png
	Oct 10 2025, 9:29 AM

	F66740872: Screenshot 2025-10-10 at 11.28.06.png
	Oct 10 2025, 9:29 AM

	F66740867: Screenshot 2025-10-10 at 11.26.42.png
	Oct 10 2025, 9:29 AM

	F66710461: Screenshot 2025-09-29 at 17.04.32.png
	Sep 29 2025, 3:06 PM

	F66097924: Screenshot 2025-09-22 at 17.51.20.png
	Sep 22 2025, 3:51 PM

	F66097833: Screenshot 2025-09-22 at 17.41.33.png
	Sep 22 2025, 3:41 PM

	F66097792: Screenshot 2025-09-22 at 17.33.01.png
	Sep 22 2025, 3:34 PM

	F66097778: Screenshot 2025-09-22 at 17.30.13.png
	Sep 22 2025, 3:31 PM

[MEX] M3.3.2 - editing snaks on referencesClosed, ResolvedPublicActions