Page MenuHomePhabricator
Create Task
Maniphest T405249

Unify page_namespace_id spelling as contextual attribute for Java and Swift client libraries
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Description

Recently, while testing xLab, we found that the page_namespace_id contextual attributes is spelled as page_namespace and page_namespace_id indistinctly in metrics-platform. We agreed on considering page_namespace_id as the right choice.

This ticket aims to fix the spelling for that contextual attributes in Java and Swift metrics-platform client libraries

Acceptance Criteria

  • All references to the page_namespace_id contextual attributes in Java and Swift metrics-platform client libraries are spelled correctly

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
tests: page_namespace -> page_namespace_idPhuedxmediawiki/extensions/MetricsPlatformmaster+7 -7
Customize query in gerrit
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
[Java] page_namespace -> page_namespace_idrepos/data-engineering/metrics-platform!110phuedxwork/phuedx/page_namespace_idmain
Customize query in GitLab

Related Objects

Event Timeline

Sfaci created this task.Sep 22 2025, 3:55 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 22 2025, 3:55 PM
Sfaci added projects: Test Kitchen, Essential-Work.Sep 22 2025, 3:56 PM
Sfaci mentioned this in T405098: xLab: Some contextual attributes are deprecated/old/misspelled.Sep 23 2025, 10:39 AM
JVanderhoop-WMF triaged this task as Medium priority.Oct 14 2025, 4:47 PM
JVanderhoop-WMF moved this task from Incoming to READY TO GROOM on the Test Kitchen board.
gerritbot added a comment.Nov 14 2025, 5:26 AM

Change #1204997 had a related patch set uploaded (by Phuedx; author: Phuedx):

[mediawiki/extensions/MetricsPlatform@master] tests: page_namespace -> page_namespace_id

https://gerrit.wikimedia.org/r/1204997

gerritbot added a project: Patch-For-Review.Nov 14 2025, 5:26 AM
phuedx subscribed.Nov 14 2025, 5:27 AM

Once the patch above is merged, I think we can call this Done™ per https://codesearch.wmcloud.org/search/?q=page_namespace&files=&excludeFiles=swift%24&repos=Extension%3AMetricsPlatform%2Crepos%2Fdata-engineering%2Fmetrics-platform.

phuedx claimed this task.Nov 14 2025, 5:28 AM
phuedx edited projects, added: Test Kitchen (Experiment Platform Sprint 15); removed: Test Kitchen.
phuedx moved this task from Ready for Development to Needs Review on the Test Kitchen (Experiment Platform Sprint 15) board.
phuedx set the point value for this task to 1.
phuedx updated the task description. (Show Details)
Sfaci added a comment.Nov 14 2025, 8:20 AM
In T405249#11373264, @phuedx wrote:

Once the patch above is merged, I think we can call this Done™ per https://codesearch.wmcloud.org/search/?q=page_namespace&files=&excludeFiles=swift%24&repos=Extension%3AMetricsPlatform%2Crepos%2Fdata-engineering%2Fmetrics-platform.

I can see a few cases where page_namespace is still spelled as page_namespace in some json files that contain some configuration for java test cases. Aren't they relevant?

gerritbot added a comment.Nov 14 2025, 8:26 AM

Change #1204997 merged by jenkins-bot:

[mediawiki/extensions/MetricsPlatform@master] tests: page_namespace -> page_namespace_id

https://gerrit.wikimedia.org/r/1204997

phuedx mentioned this in rEMPLb859da8a8186: tests: page_namespace -> page_namespace_id.Nov 14 2025, 8:26 AM
Maintenance_bot removed a project: Patch-For-Review.Nov 14 2025, 8:30 AM
ReleaseTaggerBot added a project: MW-1.46-notes (1.46.0-wmf.3; 2025-11-19).Nov 14 2025, 9:00 AM
CodeReviewBot added a project: Patch-For-Review.Nov 14 2025, 11:54 AM

phuedx opened https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/110

[Java] page_namespace -> page_namespace_id

phuedx added a comment.Nov 14 2025, 11:55 AM
In T405249#11373456, @Sfaci wrote:

I can see a few cases where page_namespace is still spelled as page_namespace in some json files that contain some configuration for java test cases. Aren't they relevant?

Good spot! They're not relevant but they'll undoubtedly cause confusion!

CodeReviewBot added a comment.Nov 14 2025, 1:51 PM

sfaci merged https://gitlab.wikimedia.org/repos/data-engineering/metrics-platform/-/merge_requests/110

[Java] page_namespace -> page_namespace_id

Sfaci moved this task from Needs Review to To Deploy on the Test Kitchen (Experiment Platform Sprint 15) board.Nov 14 2025, 1:52 PM
Maintenance_bot removed a project: Patch-For-Review.Nov 14 2025, 2:31 PM
Sfaci moved this task from To Deploy to Done on the Test Kitchen (Experiment Platform Sprint 15) board.Nov 21 2025, 12:18 AM
Milimetric closed this task as Resolved.Nov 25 2025, 4:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits