Page MenuHomePhabricator

If dark mode is enabled on Android the other date of the What came first game is white text on white background
Open, Needs TriagePublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • In Android enable dark mode
  • In the Wikipedia app (there I also have a dark mode enabled) play the What came first game
  • Give a correct answer (if you answer false, one date has red and one green background)

What happens?:

If you selected the right answer, then one date (the one you selected) is white text on green background and one text is white text on white background which means one can't read the date.

What should have happened instead?:

With dark mode, the text should be black on white background or white on dark background.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia):

Wikipedia app v 2.7.50549

Other information (browser name/version, screenshots, etc.):

Event Timeline

Dbrant subscribed.

@Prototyperspective I'm afraid I'm not able to reproduce this - the colors are appearing correctly. I noticed you're using a slightly outdated version of the app; could you try the very latest? And could you also provide your Android version?

I tried it with the latest version 2.7.50549 and it's the same there. I have a device many people have so I don't think I'm the only having this even if many devices don't have this problem. Maybe the background needs to be defined explicitly for dark mode. It could be similar to the issue T362471 which is solved by now. Android version 11.

I have a device many people have so I don't think I'm the only having this even if many devices don't have this problem.

We haven't received any other similar user reports, and I'm not seeing this behavior on an Android 11 device...

I would suggest the person who coded the text simply takes a quick look at the UI element to check how the background color is set. Other than that: would it help if I send you my device model name in a private message?

I would suggest the person who coded the text simply takes a quick look at the UI element to check how the background color is set. Other than that: would it help if I send you my device model name in a private message?

Thanks; this element was coded by me; I have taken a look at it; and the background color is set the same way as every other element on the screen. (and it works on all devices to which we have access.)
It would definitely help to have your exact device model.

First of all here's a screenshot of how it looks like. Ok, thanks again. I'll send you a pm. I think other apps have similar issues but there usually the text is readable albeit at times barely – if other apps somewhat fail with this and/or it's caused by the device's software then that doesn't mean the Wikipedia app can't make it better and have all texts readable also on my type of very popular device.

scren.jpg (793×1,435 px, 313 KB)

So I did some testing and the text is white on dark background if while the result display is open disable the Android device's dark mode in the pull-down drawer and then enable it again (btw it makes the question-results sound when enabling and when disabling). It stays like that for the next question but it's white text on near-white background again when starting a new What came before quiz.

I suspect that the dark mode of the Android device tries to make the text white so it can be seen on the dark background but doesn't manage to just recolor the text so recolors that div/whatever of the box that contains the text. It would be great if you could link the code file or code line where that text is defined, it's well possible I could identify the probable cause or a potential solution by this which could be fast to test out. I would search in the code repo myself but it's not so simple to find.