Page MenuHomePhabricator

Multi-line global renaming notes visually ruins the queue view
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Accept or reject a global rename request with a multi-line note.
  • See how the renaming note escapes from the <dl> list and creates a new paragraph.

What happens?:

Starting from the second line, the multi-line renaming notes escapes from the list and creates its own paragraph.

What should have happened instead?:

It should stay inside the list. Alternatively, use another format (e.g., tables) that keeps everything consistant.

Software version (on Special:Version page; skip for WMF-hosted wikis like Wikipedia): Meta-Wiki

Other information (browser name/version, screenshots, etc.):

Examples: Special:GlobalRenameQueue/request/153819 (renamers only) / Demostration in Meta-Wiki discussion

圖片.png (936×1 px, 96 KB)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly point to the codebase URL and provide clear steps to help a contributor get set up for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

(removing MediaWiki-User-rename tag as this specific functionality is provided by the CentralAuth extension rather than by core MediaWiki :))

Xaloria changed the task status from Open to In Progress.Sep 26 2025, 3:14 PM
Xaloria subscribed.

The problem arises because multi-line renaming notes in the Global Rename Queue spill out of the <dl> list and create new paragraphs. This makes the queue view look messy. Line breaks in the notes are seen as <p> elements, which go outside the <dd> container. A simple solution is to replace line breaks with <br> tags when displaying the text. This would keep the text within the <dd> element. Another option is to use a table or a structured <div> for notes. This would help keep multi-line content visually consistent and stop layout issues. A quick fix using just CSS is also available. By applying white-space: pre-wrap; to the <dd> element, you can preserve line breaks without disrupting the list structure. Any of these solutions would keep multi-line notes looking neat and ensure a consistent queue view.

Pppery changed the task status from In Progress to Open.Dec 29 2025, 4:22 AM

Change #1221700 had a related patch set uploaded (by HarshBaldaniya134; author: HarshBaldaniya134):

[mediawiki/extensions/CentralAuth@master] CentralAuth: Fix multiline global rename notes breaking queue view

https://gerrit.wikimedia.org/r/1221700

Hi! This patch fixes T405320 by keeping multi-line rename notes inside the list
structure in Special:GlobalRenameQueue, avoiding layout issues.

Happy to adjust if a different approach is preferred. Thanks!

Change #1221700 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] CentralAuth: Fix multiline global rename notes breaking queue view

https://gerrit.wikimedia.org/r/1221700

matmarex assigned this task to HarshBaldaniya134.
matmarex subscribed.

Thanks for the patch!

I wonder if we should keep this task open - release note generator seems to rely on opened tasks.

@1F616EMO What do you mean by "release note generator"?