Instead of linking the help page in a new tab, it would be better to implement it as a popup with a short explanation of the help page, then add a link in that popup to the actual help page.
Description
Details
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| Help page should be a popup | Viktoria Hillerud WMSE | mediawiki/extensions/Wikispeech | master | +118 -11 |
Related Objects
Event Timeline
I realized that this task, T405330 and T395320 are more connected than I first thought. I've been thinking if it would be better to actually write a shared dialouge-base to minimize duplication, but then I realize that all the dialogues does different things anyways, so it might still be better to create a new module for this task anyway.
Anyway, that would make what I've done so far in T395320 kind of useless, so maybe it is better to stick with how I have done now, and revisit these tasks in the future to avoid duplication.
Edit: When having a closer look, I think its good if the logic between this task and T395320 is more important to have similar or shared, than including T405330, since that has a lot of settings to it that is not relevant for the other tasks.
Change #1217175 had a related patch set uploaded (by Viktoria Hillerud WMSE; author: Viktoria Hillerud WMSE):
[mediawiki/extensions/Wikispeech@master] Help page should be a popup
An important aspect of this is the actual content of the popup. What information should go there and what should be saved fot the help page? It may be worth looking at other well established extensions, like VisualEditor, and other functions.
Yes, ofcourse! Right now, I only took some of the text from the help page itself but I can investigate more if this is what we want
We discussed this and concluded that it's best to continue keeping the help text in the repo for now. However, we should also create a follow up task to explore how to best select which text is shown in the help popup, perhaps by reading from the existing help page. This would make it easier to keep everything in sync and avoid duplication.
Add this to the list of configuration options :
$wgWikispeechHelpPage = "https://www.mediawiki.org/wiki/Special:MyLanguage/Help:Extension:Wikispeech";
Since this needs rebasing, but also other patches that will handle this area, it's better if I wait for those to be merged before continuing with this, since it otherwise probably will collide again.
Change #1217175 merged by jenkins-bot:
[mediawiki/extensions/Wikispeech@master] Help page should be a popup