Page MenuHomePhabricator

Remove residual uses of ZObjectKeyFactory and createZObjectKey().asString()
Closed, ResolvedPublicBUG REPORT

Description

Description

Residual createZObjectKey.asString()

> rg asString
src/builtins.js
964:			const key = createZObjectKey( nextType ).asString();

function-schemata/javascript/benchmarks/schemaBenchmarks.js
57:		failedResponse = ZObjectKeyFactory.create( invalidZObject ).asString();

Residual ZObjetKeyFactory:

> rg ZObjectKeyFactory

function-schemata/javascript/benchmarks/schemaBenchmarks.js
14: * ZObjectKeyFactory with normal Z7 x 1,019 ops/sec ±1.93% (88 runs sampled)
15: * ZObjectKeyFactory with invalid object x 54,151 ops/sec ±1.06% (87 runs sampled)
24:const { isZObject, ZObjectKeyFactory } = require( '../src/utils' );
50:suite.add( 'ZObjectKeyFactory with invalid object', () => {
57:		failedResponse = ZObjectKeyFactory.create( invalidZObject ).asString();

in function evaluator

executors/python3/utils.py
102:        # TODO (T293915): Use ZObjectKeyFactory or similar to create string representations.

executors/javascript-wasmedge/utils.js
36:		// TODO (T293915): Use ZObjectKeyFactory to create string representations.

Completion checklist

Details

Related Changes in Gerrit:
Related Changes in GitLab:
TitleReferenceAuthorSource BranchDest Branch
Use stable stringification when comparing list element types.repos/abstract-wiki/wikifunctions/function-evaluator!621apineapine-stable-stringificationmain
Customize query in GitLab

Event Timeline

Change #1321556 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-07-27-212343 to 2026-08-04-215640

https://gerrit.wikimedia.org/r/1321556

Change #1321556 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade evaluators from 2026-07-27-212343 to 2026-08-04-215640

https://gerrit.wikimedia.org/r/1321556