Page MenuHomePhabricator
Create Task
Maniphest T405354

Enforce trailing_comma_in_multiline linter rule in CheckUser
Closed, ResolvedPublic
Actions

Description

In order to follow a consistent style when declaring arrays, the trailing_comma_in_multiline rule should be added to the .phpcs.xml file in CheckUser, so that it is enforced by the checks performed when submitting patches to Gerrit.

A priori, we want the rule to only apply to arrays (i.e. the default value for the PHPCS elements configuration option).

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
phpcs: Enforce trailing commas in arraysmediawiki/extensions/CheckUsermaster+6 -0
phpcs: Fix array formatting (add trailing commas)mediawiki/extensions/CheckUsermaster+856 -845
Customize query in gerrit

Event Timeline

hector.arroyo created this task.Sep 23 2025, 1:37 PM
Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptSep 23 2025, 1:37 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Dreamy_Jazz moved this task from Inbox to Engineering on the Trust and Safety Product Team board.Sep 23 2025, 2:14 PM
hector.arroyo updated the task description. (Show Details)Sep 29 2025, 8:38 AM
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)); removed Trust and Safety Product Sprint (Sprint Dadar Gulung (September 8 - September 26)).Sep 29 2025, 9:05 AM
OKryva-WMF moved this task from Priority backlog to Maintenance ready on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
OKryva-WMF added a project: Essential-Work.Sep 29 2025, 11:25 AM
OKryva-WMF edited projects, added Product Safety and Integrity; removed Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)).
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)); removed Product Safety and Integrity.
OKryva-WMF edited projects, added Product Safety and Integrity; removed Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)), Trust and Safety Product Team.
OKryva-WMF edited projects, added Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)); removed Product Safety and Integrity.Sep 29 2025, 11:27 AM
OKryva-WMF removed a project: Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)).Sep 29 2025, 11:34 AM
OKryva-WMF added a project: Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)).
hector.arroyo moved this task from Maintenance ready to Ready on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Sep 30 2025, 10:03 AM
hector.arroyo moved this task from Ready to In progress on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.
gerritbot added a comment.Sep 30 2025, 10:17 AM

Change #1192515 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] phpcs: Enforce trailing commas in arrays

https://gerrit.wikimedia.org/r/1192515

gerritbot added a project: Patch-For-Review.Sep 30 2025, 10:17 AM
gerritbot added a comment.Sep 30 2025, 10:40 AM

Change #1192520 had a related patch set uploaded (by Harroyo-wmf; author: Harroyo-wmf):

[mediawiki/extensions/CheckUser@master] phpcs: Fix array formatting (add trailing commas)

https://gerrit.wikimedia.org/r/1192520

hector.arroyo changed the task status from Open to In Progress.Sep 30 2025, 11:18 AM
hector.arroyo claimed this task.
hector.arroyo added a comment.EditedOct 2 2025, 12:32 PM

CheckUser #1192520 currently shows 213 linter errors for Multi-line array without trailing comma, down from 816 shown in the parent patch CheckUser #1192515.

hector.arroyo moved this task from In progress to Needs review on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.Oct 2 2025, 2:03 PM
gerritbot added a comment.Oct 2 2025, 3:07 PM

Change #1192520 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] phpcs: Fix array formatting (add trailing commas)

https://gerrit.wikimedia.org/r/1192520

hector.arroyo closed this task as Resolved.Oct 2 2025, 3:09 PM
hector.arroyo moved this task from Needs review to Done on the Product Safety and Integrity (Sprint Apfel Strudel (Sep 29 - Oct 17)) board.

The patches are being merged now, therefore I'm closing the ticket since there are no functional changes to test.

gerritbot added a comment.Oct 2 2025, 3:18 PM

Change #1192515 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] phpcs: Enforce trailing commas in arrays

https://gerrit.wikimedia.org/r/1192515

Maintenance_bot removed a project: Patch-For-Review.Oct 2 2025, 3:31 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.22; 2025-10-07).Oct 2 2025, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits