Page MenuHomePhabricator

Grid: Use `gap`, not just `column-gap` as sensible default
Closed, ResolvedPublic1 Estimated Story Points

Description

Background

While working on MediaWiki-extensions-ReadingLists Grid layout, it became quite obvious that a sensible default for all Grids should be column and row gaps (gutter).
In the original implementation, with limiting demos, the column grid was the only implemented one.

Goal

Use gap shorthand.

image.png (2,784×488 px, 110 KB)

Acceptance criteria for done

  • Use general gap shorthand

Event Timeline

aude set the point value for this task to 1.Sep 23 2025, 4:36 PM
SToyofuku-WMF subscribed.

Assigning this to you explicitly even though it seems like you already got it (sorry!)

Change #1190723 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] styles, Grid: Use `gap` shorthand for both, rows and columns

https://gerrit.wikimedia.org/r/1190723

Change #1190723 merged by jenkins-bot:

[design/codex@main] styles, Grid: Use `gap` shorthand for both, rows and columns

https://gerrit.wikimedia.org/r/1190723

Change #1191228 had a related patch set uploaded (by VolkerE; author: VolkerE):

[design/codex@main] styles, Grid: Refining container mixin with limiting to row gap params

https://gerrit.wikimedia.org/r/1191228

Change #1191228 merged by jenkins-bot:

[design/codex@main] styles, Grid: Refining container mixin with limiting to row gap params

https://gerrit.wikimedia.org/r/1191228

Volker_E moved this task from Backlog to Pending Release on the Codex board.
Volker_E updated the task description. (Show Details)
Volker_E added a subscriber: LMora-WMF.

Change #1191541 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update Codex from v2.3.1 to v2.3.2

https://gerrit.wikimedia.org/r/1191541

Change #1191541 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v2.3.1 to v2.3.2

https://gerrit.wikimedia.org/r/1191541

Izno renamed this task from Grid: Use `gap`, not just `column-gap` as sensitive default to Grid: Use `gap`, not just `column-gap` as sensible default.Sep 26 2025, 4:02 PM