Page MenuHomePhabricator

Minor improvements to the country page
Closed, ResolvedPublicFeature

Description

Feature summary: Better organize headings and information within the country page.

Right now the page looks like this:

country-page-before.png (568×1 px, 61 KB)

To complete this task, it should look like this:

country-page-after.png (590×996 px, 53 KB)

Changes must be made to the template country.html, inside the templates folder.

Benefits: With this little improvement, the country page will be a little clearer and friendlier.

Event Timeline

Hello @Pepe_piton I would like to work on this task. When trying to set up the code I saw that I need to set up a basic Flask WSGI webservice. For me to set up I need to request membership for toolforge. I just want to confirm if I am on the right track in setting up.

Hi @Oreoluwa! Thanks for joining the project! The requirement for a basic Flask WSGI webservice is only for those who want to set up Paulina on another production server. Outreachy contributors do not need to do this part.

Outreachy contributors just need to:

If you have any other questions about the setup, please write back to us. Best!

Hello @Pepe_piton , I would like to work on this task. I would like to kindly request to be added as a trusted contributor so I can fully participate in project tasks and updates. Thanks!

I assigned this task to @Oreoluwa.

@Nurah_Wakili I assigned this other task to you: T402301.

Thanks!

hello, @Pepe_piton
i made a merge request related this issue:-https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/29
I'd appreciate it if you could take a look at my work and provide feedback. I want to make sure I'm meeting expectations and understand any areas for improvemen

Hello @Pepe_piton,
I made a merge request for this task : https://gitlab.wikimedia.org/toolforge-repos/paulina/-/merge_requests/46
I'd appreciate your feedback.
Thanks

Hello @Pepe_piton

I also made a merge request for this issue. I'd appreciate your feedback : merge request

Hello, everyone! I've been revising your Pull requests. Here's some feedback

@System625
I like that you listed the changes and added a test plan
you paid attention to the h1 category hierarchy

@Dipanshu1223
good implementation
The only detail I see is that we have an h2 (“Copyright terms”) within another h2 (country name)

@Aradhya05
thanks for paying attention to reorganizing the h hierarchy. However, I think the resulting hierarchy is not correct. If “Public domain statistics" is an h4, I would not put the explanatory text as an h3

@Joyakinyi
The PR includes the solution to another task. I suggest you use 1 branch per task whenever possible
If you can include the name if the ticket in the name of the PR that’s helpful for us to keep things tidy

@Oluwatumininu.m
good implementation
If you can include the name if the ticket in the name of the PR that’s helpful for us to keep things tidy

Overall, you've all done a good job.
We'll merge one of the solutions into the main branch shortly and close the task.
I advise the rest of the applicants not to pick up this microtask anymore.

@Oluwatumininu.m
good implementation
If you can include the name if the ticket in the name of the PR that’s helpful for us to keep things tidy

Thank you very much for the feedback. I will take note for my next tasks.

@System625
I like that you listed the changes and added a test plan
you paid attention to the h1 category hierarchy

Thank you for the feedback! I appreciate

Good morning!

I have worked on this issue as a warm-up and would appreciate your feedback and comments @Pepe_piton and @Nat_WDU.
Find attached the link to my Merge Request

Regards,
Farmata.

Hello @Pepe_piton I have rebased the branch to only have one commit related to this specific task .

Thank you for the feedback!

@Joyakinyi thanks for fixing it!

@Miiswom just reviewed your, good job!

@Nat_WDU thank you very much for the feedback!

Hello @Nat_WDU and @Pepe_piton, I trust you are both doing well. I know this task has been resolved but I would very much like to get your feedback on my work as it would mean a lot to me and aid me in learning more from you. When I picked up the task last week, it was still open and I finished it but could not push my work till yesterday after I followed the direction of my peers. Here is the link to my MR Merge Request Link{F66750056}.

Thank you in anticipation of your response.

Hello, @Chumzine ! I've reviewed and closed your MR. The implementation was correct, you may record this as a contribution. Thanks!

Hi @Nat_WDU, thank you so much for the feedback. Okay. You're welcome!