Page MenuHomePhabricator
Create Task
Maniphest T405398

Update the CancelInactives script to handle paused donations
Closed, ResolvedPublic
Actions

Description

Right now it's just checking if there hasn't been activity in the last 60 days

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Clarify comment on when we cancel inactiveswikimedia/fundraising/crmmaster+2 -1
Don't cancel paused recurringswikimedia/fundraising/crmmaster+59 -0
Customize query in gerrit

Event Timeline

Cstone created this task.Sep 23 2025, 7:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2025, 7:15 PM
AKanji-WMF moved this task from Triage to Sprint +1 on the Fundraising-Backlog board.Sep 29 2025, 8:24 PM
AKanji-WMF moved this task from Sprint +1 to Current Sprint on the Fundraising-Backlog board.Oct 7 2025, 7:19 PM
AKanji-WMF added a project: Fundraising Sprint: Temp file pura.Oct 7 2025, 8:15 PM
Ejegg claimed this task.Oct 15 2025, 2:03 PM
Ejegg triaged this task as Medium priority.
Ejegg moved this task from Backlog to Doing on the Fundraising Sprint: Temp file pura board.
gerritbot added a comment.Oct 15 2025, 2:23 PM

Change #1196462 had a related patch set uploaded (by Ejegg; author: Ejegg):

[wikimedia/fundraising/crm@master] Don't cancel paused recurrings

https://gerrit.wikimedia.org/r/1196462

gerritbot added a project: Patch-For-Review.Oct 15 2025, 2:23 PM
Ejegg moved this task from Doing to Ready for Review on the Fundraising Sprint: Temp file pura board.Oct 15 2025, 2:28 PM
Lars moved this task from Ready for Review to Being Reviewed on the Fundraising Sprint: Temp file pura board.Oct 15 2025, 6:22 PM
gerritbot added a comment.Oct 15 2025, 7:12 PM

Change #1196515 had a related patch set uploaded (by Lars SG; author: Lars SG):

[wikimedia/fundraising/crm@master] Clarify comment on when we cancel inactives

https://gerrit.wikimedia.org/r/1196515

gerritbot added a comment.Oct 15 2025, 7:14 PM

Change #1196462 abandoned by Lars SG:

[wikimedia/fundraising/crm@master] Don't cancel paused recurrings

Reason:

We are only actually cancelling these based on the next scheduled date, not inactivity, so there is no issue

https://gerrit.wikimedia.org/r/1196462

gerritbot added a comment.Oct 15 2025, 7:33 PM

Change #1196515 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Clarify comment on when we cancel inactives

https://gerrit.wikimedia.org/r/1196515

Maintenance_bot removed a project: Patch-For-Review.Oct 15 2025, 8:32 PM
Ejegg moved this task from Being Reviewed to Done on the Fundraising Sprint: Temp file pura board.Oct 15 2025, 9:06 PM

Hah, it was checking the next_sched_contribution_date all along. Lars fixed the comment that suggested otherwise.

XenoRyet closed this task as Resolved.Oct 20 2025, 7:15 PM
XenoRyet set Final Story Points to 2.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits