Page MenuHomePhabricator
Create Task
Maniphest T405408

"Display title" broken in visual editor
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  1. Edit page that includes localized equivalent of {{DISPLAYTITLE:...}} using VisualEditor.
  2. Observe the diff.

What happens?:
String DISPLAYTITLE: is prepended to localized equivalent of {{DISPLAYTITLE:...}} in the article's wikitext.

What should have happened instead?:
The {{DISPLAYTITLE:…}} tag in the article's wikitext shouldn't be changed.

Other information (browser name/version, screenshots, etc.):
Example: https://de.wikipedia.org/w/index.php?diff=259967738
This bug was observed after T402322 was resolved.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Display title fixMedeliusmediawiki/extensions/VisualEditormaster+11 -3
Customize query in gerrit

Related Objects

Event Timeline

Derkoenig created this task.Sep 23 2025, 8:42 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 23 2025, 8:42 PM
Derkoenig updated the task description. (Show Details)Sep 23 2025, 8:45 PM
medelius claimed this task.Sep 23 2025, 8:48 PM
medelius added a project: Editing-team (Kanban Board).
gerritbot added a comment.Sep 23 2025, 10:02 PM

Change #1190785 had a related patch set uploaded (by Medelius; author: Medelius):

[mediawiki/extensions/VisualEditor@master] WIP: Display title fix

https://gerrit.wikimedia.org/r/1190785

gerritbot added a project: Patch-For-Review.Sep 23 2025, 10:02 PM
Johannnes89 subscribed.Sep 24 2025, 5:34 AM
matej_suchanek subscribed.Sep 24 2025, 7:34 AM
gerritbot added a comment.Sep 24 2025, 3:29 PM

Change #1190785 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Display title fix

https://gerrit.wikimedia.org/r/1190785

Maintenance_bot removed a project: Patch-For-Review.Sep 24 2025, 3:32 PM
ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.21; 2025-09-30).Sep 24 2025, 4:00 PM
DLynch moved this task from Inbox to QA on the Editing-team (Kanban Board) board.Sep 24 2025, 5:09 PM
DLynch added a project: Editing QA.
DLynch subscribed.

This was my fault via poor advice -- I thought that Parsoid was still handling localizing this for us, as it was before the switch to treating it as parserfunction markup, and I didn't actually check that I was right about that. (With the caveat this is still less broken than it was before T402322, because it does break the displaytitle, but at least does it without jamming the word DISPLAYTITLE onto the front of the article.)

QA: patch makes it so that whatever alias was used already will be preserved, or the localized variant will be used if you're adding a new displaytitle to a page that didn't already have one. E.g. on dewiki that'd be SEITENTITEL. So, please double-check that we're not accidentally overwriting that with DISPLAYTITLE when editing an existing one.

EAkinloose closed this task as Resolved.Sep 29 2025, 4:04 PM
EAkinloose edited projects, added: Verified; removed: Editing QA.
VPuffetMichel added a project: Essential-Work.Dec 8 2025, 10:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits