Page MenuHomePhabricator

Page title not replaced by item label when viewing old revisions.
Closed, ResolvedPublic


->Difference between revisions of "Data:Q2075"

->Difference between revisions of "Japanese language"

I think the diff heading should be the same on both diffs because an en-label exists since the first version.

Version: unspecified
Severity: major



Event Timeline

bzimport raised the priority of this task from to High.Nov 22 2014, 12:52 AM
bzimport set Reference to bz38542.
bzimport added a subscriber: Unknown Object (MLST).

no it doesn't. the first revision doesn't have a label:

The first revision has a *link* to the en wikipedia. That is not at all the same as an english language label.

We could derive a fallback label from the language links, if we have a reliable mapping from languages to sites... That could/should be done during item creation though, not on the fly - that would be confusing.

I think it should be up to the code creating the item to generate the default labels though. Don't know what mechanism created this item here.

So... looking at the JSON, the label *is* there from the fist revision.

Apparently, the page title is replaced with the item label only if the current revision is show. For old revision, this doesn't work at all for some reason.

This is a bug, so I'll re-open this ticket. Also changing the description.

This solves the label issue but note that there also is an issue with labels and descriptions being editable.

Now it seems to be even more broken: the label is *never* shown, I always see the internal title.

*** Bug 38180 has been marked as a duplicate of this bug. ***

*** Bug 39128 has been marked as a duplicate of this bug. ***

gerrit 31657 (Status Merged) links here, but not linked back. Is this fixed?

Seems to be fixed with the Gerrit change.

Verified in Wikidata demo for sprint 24