Page MenuHomePhabricator

ReadingList extension should show default (Special:Page) heading
Closed, ResolvedPublic2 Estimated Story Points

Description

Background

Current implementation is not only unnecessary additionally code, it is also causing accessbility issues and will cause issues with a possible expansion to mobile and MinervaNeue or other skins.

Goal

Remove the extraneous code and rely on default core heading

Requirement

Scope: Desktop web (Vector 2022) and mobile web (Minerva).

  • The ReadingList extension must display the default Special page heading (<h1> or <h2> consistent with other Special: pages).
  • The heading “Saved pages” must be shown for default lists as well as custom reading lists.
  • The accessibility structure (heading levels, ARIA associations) must match MediaWiki’s standard Special page template.
  • No redundant custom heading markup or logic should remain in the extension.
  • Future compatibility with MinervaNeue and other skins must be preserved.

BDD

Feature: Default heading displayed on Special:ReadingLists

  Scenario: Viewing default saved pages list
    Given I open `Special:ReadingLists/<username>/<listid>` for my default saved pages list
    When the page loads
    Then a visible heading “Saved pages” is displayed
    And the heading follows the standard Special page structure (e.g., `<h1>` or `<h2>`)

Test Steps

Test Case 1: Default list heading

  1. Log in and open Special:ReadingLists/<username>/<listid> for the default list.
  2. Inspect the page structure in DevTools.
  3. AC1: The heading “Saved pages” is visible.
  4. AC2: The heading uses the same level and styling as standard Special page headings (<h1> or <h2> depending on skin).
  5. AC3: No duplicate or redundant heading elements are present.

QA Results - Beta

ACStatusDetails
1T405431#11248353
2T405431#11248353
3T405431#11248353

QA Results - Prod

ACStatusDetails
1T405431#11248355
2T405431#11248355
3T405431#11248355

Acceptance criteria for done

  • Unhide the default heading
  • Remove the then superfluous code

Details

Event Timeline

Change #1190808 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/extensions/ReadingLists@master] app: Use default core heading

https://gerrit.wikimedia.org/r/1190808

Change #1190808 merged by jenkins-bot:

[mediawiki/extensions/ReadingLists@master] Use default core Special:Page heading

https://gerrit.wikimedia.org/r/1190808

Jdlrobson-WMF renamed this task from ReadingList extension should show default (Special:Page) heading to [subtask] ReadingList extension should show default (Special:Page) heading.Sep 25 2025, 3:42 PM
Jdlrobson-WMF triaged this task as High priority.
Jdlrobson-WMF set the point value for this task to 0.
Volker_E changed the point value for this task from 0 to 2.Sep 25 2025, 4:53 PM
Jdlrobson-WMF renamed this task from [subtask] ReadingList extension should show default (Special:Page) heading to ReadingList extension should show default (Special:Page) heading.Sep 26 2025, 7:49 AM

For this issue, noticed that we have duplicate headings on the Special:ReadingLists (base page, which shows all lists for a user)

Created follow up task, which could be marked as subtask and uploaded a patch:

https://phabricator.wikimedia.org/T406168

Edtadros subscribed.

@Volker_E, I'm not entirely sure what I'm supposed to be validating here. Is this the same as T406168?

Special:Readinglists/{Username}/{listid}

this was showing an h2 level heading with "Saved pages". Now the h2 level heading and description are only displayed for custom reading lists (created in mobile apps)

Screenshot 2025-10-06 at 4.33.19 PM.png (2,940×1,672 px, 183 KB)

Screenshot 2025-10-06 at 4.33.38 PM.png (2,940×1,672 px, 169 KB)

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Default list heading

  1. Log in and open Special:ReadingLists/<username>/<listid> for the default list.
  2. Inspect the page structure in DevTools.
  3. AC1: The heading “Saved pages” is visible.
  4. AC2: The heading uses the same level and styling as standard Special page headings (<h1> or <h2> depending on skin).
  5. AC3: No duplicate or redundant heading elements are present.

screenshot 232.png (1,632×651 px, 129 KB)

screenshot 231.png (1,632×651 px, 123 KB)

Test Result - Prod

Status: ✅ PASS
Environment: testwiki
OS: macOS Sequoia 15.5
Browser: Chrome Canary (latest as of test date)
Device: MS
Emulated Device: NA

Test Case 1: Default list heading

  1. Log in and open Special:ReadingLists/<username>/<listid> for the default list.
  2. Inspect the page structure in DevTools.
  3. AC1: The heading “Saved pages” is visible.
  4. AC2: The heading uses the same level and styling as standard Special page headings (<h1> or <h2> depending on skin).
  5. AC3: No duplicate or redundant heading elements are present.

screenshot 234.png (1,632×651 px, 147 KB)

screenshot 233.png (1,632×651 px, 88 KB)

Edtadros added a project: Verified.

Assigning Verified because I'm pretty sure it will be resolved.